Add an optional ForOptions field to the ResourceReconciler#673
Closed
annismckenzie wants to merge 1 commit intoreconcilerio:mainfrom
Closed
Add an optional ForOptions field to the ResourceReconciler#673annismckenzie wants to merge 1 commit intoreconcilerio:mainfrom
annismckenzie wants to merge 1 commit intoreconcilerio:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
- Coverage 59.96% 59.88% -0.08%
==========================================
Files 39 39
Lines 3559 3565 +6
==========================================
+ Hits 2134 2135 +1
- Misses 1315 1319 +4
- Partials 110 111 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Daniel Lohse <info@asapdesign.de>
a6e1958 to
6b9408e
Compare
Member
|
Thanks for opening. I agree these options are worth exposing. A few questions:
|
Member
|
Implemented in #676. Thanks for the proposal @annismckenzie |
Contributor
Author
|
So sorry, I just saw your comments above – your version will work nicely, thank you! 🤝 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one of our projects we've used the predicates functionality that the controller runtime provides. This was easy to add but might cause issues if we keep finding things to tweak. Unfortunately, I didn't find another, less intrusive way to add this feature. There are tests missing which I'd add if you're willing to accept this PR.