src/state/keyboardEventsMiddleware.ts (1)

44-125: Throttle cooldown can get stuck when the callback exits early.

When the trailing timeout fires, callback() can return before resetting timeoutId/rafId (e.g., Enter key path, invalid key, or accessibility disabled). Because the timeout handler only clears IDs when no payload exists, this leaves timeoutId non‑null and blocks subsequent keydowns. Ensure cleanup runs on every exit.

🛠️ Suggested fix: always clear IDs via try/finally

-    const callback = () => {
-      const currentState = listenerApi.getState();
-      const accessibilityLayerIsActive = currentState.rootProps.accessibilityLayer !== false;
-      if (!accessibilityLayerIsActive) {
-        return;
-      }
-      const { keyboardInteraction } = currentState.tooltip;
-      const key = latestKeyboardActionPayload;
-      if (key !== 'ArrowRight' && key !== 'ArrowLeft' && key !== 'Enter') {
-        return;
-      }
+    const callback = () => {
+      try {
+        const currentState = listenerApi.getState();
+        const accessibilityLayerIsActive = currentState.rootProps.accessibilityLayer !== false;
+        if (!accessibilityLayerIsActive) {
+          return;
+        }
+        const { keyboardInteraction } = currentState.tooltip;
+        const key = latestKeyboardActionPayload;
+        if (key !== 'ArrowRight' && key !== 'ArrowLeft' && key !== 'Enter') {
+          return;
+        }
        ...
-      listenerApi.dispatch(
-        setKeyboardInteraction({
-          active: true,
-          activeIndex: nextIndex.toString(),
-          activeCoordinate: coordinate,
-        }),
-      );
-      rafId = null;
-      timeoutId = null;
+        listenerApi.dispatch(
+          setKeyboardInteraction({
+            active: true,
+            activeIndex: nextIndex.toString(),
+            activeCoordinate: coordinate,
+          }),
+        );
+      } finally {
+        rafId = null;
+        timeoutId = null;
+      }
     };

test/state/throttling.spec.ts (1)

159-164: Replace as any with as unknown as SyntheticEvent to match the codebase pattern.

The as any violates the coding guideline that forbids any types. While the suggested satisfies approach is cleaner, the related test file (test/state/externalEventsMiddleware.spec.ts) uses as unknown as SyntheticEvent for the same mock pattern. This is the established pattern in the codebase for typing mock events that satisfy React's SyntheticEvent interface.

Apply this change to lines 159-164 and 180-184 (and any other occurrences in this file):

  reactEvent: mockEvent as any,
+ reactEvent: mockEvent as unknown as SyntheticEvent,

test/state/throttling.spec.ts (2)

142-147: Mock handler is not reset between tests.

The mockHandler is defined once at the describe block level but never reset between tests. This causes toHaveBeenCalledTimes assertions to accumulate across tests, which could lead to flaky or incorrect test results.

🐛 Proposed fix

   describe('externalEventsMiddleware', () => {
     const mockHandler = vi.fn();
     const mockEvent = {
       type: 'click',
       persist: vi.fn(),
     };

+    beforeEach(() => {
+      mockHandler.mockClear();
+    });
+
     it('should execute first event immediately (leading edge) when throttleDelay is a number', () => {

---

45-47: Also replace vi.runAllTimers() here.

For consistency with the coding guidelines, this instance should also use vi.runOnlyPendingTimers().

♻️ Proposed fix

       act(() => {
-        vi.runAllTimers();
+        vi.runOnlyPendingTimers();
       });