Reviewing files that changed from the base of the PR and between b8f09a4 and 6bf5c05.

• eslint.config.mjs (2 hunks)
• omnidoc/generateApiDoc.ts (9 hunks)
• omnidoc/readApiDoc.spec.ts (0 hunks)
• omnidoc/readProject.spec.ts (1 hunks)
• omnidoc/readProject.ts (2 hunks)
• omnidoc/simplifyType.spec.ts (1 hunks)
• src/cartesian/Area.tsx (5 hunks)
• src/cartesian/Bar.tsx (1 hunks)
• src/cartesian/ErrorBar.tsx (1 hunks)
• src/cartesian/Line.tsx (1 hunks)
• src/cartesian/Scatter.tsx (1 hunks)
• src/chart/AreaChart.tsx (1 hunks)
• src/chart/BarChart.tsx (1 hunks)
• src/chart/ComposedChart.tsx (1 hunks)
• src/chart/FunnelChart.tsx (1 hunks)
• src/chart/LineChart.tsx (1 hunks)
• src/chart/ScatterChart.tsx (1 hunks)
• src/component/Label.tsx (2 hunks)
• src/component/LabelList.tsx (2 hunks)
• src/component/Text.tsx (1 hunks)
• src/shape/Curve.tsx (2 hunks)
• src/state/cartesianAxisSlice.ts (1 hunks)
• src/state/chartDataSlice.ts (1 hunks)
• src/util/ChartUtils.ts (1 hunks)
• src/util/types.ts (6 hunks)
• www/src/docs/api/Area.ts (0 hunks)
• www/src/docs/api/AreaAPI.tsx (1 hunks)
• www/src/docs/api/BarStackAPI.tsx (2 hunks)
• www/src/docs/api/LabelAPI.tsx (5 hunks)
• www/src/docs/api/TextAPI.tsx (2 hunks)
• www/src/docs/api/ZIndexLayerAPI.tsx (1 hunks)
• www/src/docs/api/index.ts (2 hunks)

• www/src/docs/api/Area.ts
• omnidoc/readApiDoc.spec.ts

• GitHub Check: Build, Test, Pack
• GitHub Check: Analyze (javascript-typescript)

src/component/LabelList.tsx (2)

128-131: Documentation annotations align with PR objectives.

The @inline JSDoc annotation on the public ImplicitLabelListType export enables the type to be displayed inline in generated documentation and supports type reuse in TypeScript, as intended by the PR.

---

151-153: Context consumption is accurately documented.

The @consumes LabelListContext annotation correctly documents that the LabelList function consumes context via the useCartesianLabelListContext() and usePolarLabelListContext() calls (lines 156–157). This supports the omnidoc generation enhancements described in the PR.

src/state/chartDataSlice.ts (1)

11-12: LGTM! The @inline JSDoc annotation aligns with the PR's omnidoc enhancements. All types are properly defined using unknown rather than any, and all function parameters and return values are explicitly typed as per coding guidelines.

src/chart/ComposedChart.tsx (1)

9-12: JSDoc context annotation looks correct

ComposedChart is just a thin wrapper around CartesianChart, so documenting that it provides CartesianChartContext is accurate and keeps API docs aligned with other cartesian chart components.

src/cartesian/Line.tsx (1)

869-873: Line’s provides/consumes metadata matches implementation

Line wraps its render tree in LineLabelListProvider and uses cartesian chart layout/plot-area hooks, so documenting it as providing LabelListContext and consuming CartesianChartContext matches the actual behavior.

src/chart/AreaChart.tsx (1)

9-12: Accurate @provides tag for AreaChart

AreaChart delegates to CartesianChart, which owns the cartesian context, so marking AreaChart as providing CartesianChartContext is a correct and useful doc annotation.

src/component/Text.tsx (1)

58-75: Good use of @inline on shared Text helper types

Annotating TextAnchor, TextVerticalAnchor, and RenderableText with @inline is consistent with how these unions are used and should improve the generated API docs without affecting runtime behavior.

eslint.config.mjs (1)

430-437: Reasonable ESLint override for generated API docs

Scoping generatedApiDocsOverrides to www/src/docs/api/** and disabling only no-template-curly-in-string is a minimal, well-targeted relaxation for autogenerated files, and its placement in the export array ensures it takes effect after the general website rules.

Also applies to: 465-465

src/cartesian/ErrorBar.tsx (1)

281-285: Correctly documenting ErrorBar as consuming ErrorBarContext

Since ErrorBarInternal / ErrorBarImpl rely on useErrorBarContext, marking the public ErrorBar component as @consumes ErrorBarContext correctly reflects its dependency in the generated docs.

src/cartesian/Bar.tsx (1)

1075-1081: Bar’s context provides/consumes tags align with implementation

Bar sets up SetErrorBarContext, uses BarLabelListProvider (backed by CartesianLabelListContextProvider), and already depends on cartesian layout and bar stack hooks, so the new @provides ErrorBarContext / @provides LabelListContext annotations complement the existing @consumes tags accurately.

src/chart/LineChart.tsx (1)

9-12: LineChart context JSDoc matches behavior

LineChart simply delegates to CartesianChart, so adding @provides CartesianChartContext correctly advertises that it provides the cartesian chart context for consumers.

www/src/docs/api/BarStackAPI.tsx (1)

9-9: LGTM: Type definitions made explicit.

The prop types are now explicit inline unions rather than type references, improving documentation clarity and aligning with the PR's inline type metadata goals.

Also applies to: 40-40

src/chart/BarChart.tsx (1)

11-11: LGTM: Context provider documented.

The @provides annotation adds valuable metadata about the context this component provides, improving API documentation without affecting runtime behavior.

src/shape/Curve.tsx (1)

60-79: LGTM: Enhanced type documentation.

The @inline annotation enables better documentation generation by expanding the CurveType union inline, and the added @link and @see tags provide helpful references to d3-shape documentation and examples.

Also applies to: 109-110

www/src/docs/api/TextAPI.tsx (1)

171-171: LGTM: Type definitions made explicit.

The prop types are now explicit string literal unions rather than type references, improving documentation clarity and consistency with the PR's inline type metadata approach.

Also applies to: 193-193

src/util/types.ts (1)

60-65: LGTM: Inline annotations added for documentation generation.

The @inline annotations enable the omnidoc system to expand these types inline in generated documentation, improving API documentation readability. The expanded LegendType union with 'line', 'plainline', and 'rect' is an additive, backward-compatible change.

Also applies to: 73-76, 78-92, 635-640, 890-893, 1024-1051, 1070-1100

src/util/ChartUtils.ts (1)

476-480: LGTM: New public type alias improves API clarity.

The exported StackId type makes the stack identifier type explicit and reusable, improving API documentation and type consistency across the codebase.

src/state/cartesianAxisSlice.ts (1)

8-11: LGTM: Inline annotation added for documentation.

The @inline annotation enables better documentation generation for the AxisId type, consistent with the broader pattern across the codebase.

src/chart/ScatterChart.tsx (1)

11-11: LGTM: Context provider documented.

The @provides annotation adds valuable metadata about the context this component provides, improving API documentation without affecting runtime behavior.

www/src/docs/api/index.ts (1)

69-69: LGTM!

The Area entry correctly references the new AreaAPI documentation module, consistent with the PR's objective to generate Area component documentation.

src/cartesian/Scatter.tsx (1)

814-818: LGTM!

The JSDoc annotations correctly document the context relationships for the Scatter component, aligning with similar annotations added to other chart components in this PR.

src/chart/FunnelChart.tsx (1)

9-12: LGTM!

The JSDoc annotation correctly documents that FunnelChart provides CartesianChartContext, consistent with the broader PR effort to document context relationships across chart components.

omnidoc/simplifyType.spec.ts (1)

1-19: LGTM on test coverage!

Good test coverage for the simplifyType function, including edge cases for simple unions, complex object types with unions, and nested structures with the isInline parameter.

omnidoc/readProject.spec.ts (1)

925-946: LGTM!

The updated tests correctly validate the new structured return type from getTypeOf() and the inline type expansion feature. Good use of partial matchers for the complex union type assertions.

www/src/docs/api/ZIndexLayerAPI.tsx (1)

5-39: LGTM!

The prop reordering prioritizes the required zIndex prop over the optional children prop, which improves the API documentation structure. The descriptions clearly explain the z-index layering semantics and portal behavior.

src/component/Label.tsx (2)

33-36: LGTM!

The @inline annotation and export of LabelContentType enable the omnidoc system to generate expanded inline type documentation, improving the public API surface.

---

67-75: LGTM!

Good addition of LabelPosition and LabelFormatter type exports with @inline annotations. These provide clearer type documentation for consumers of the Label component API.

omnidoc/readProject.ts (1)

515-585: Well-structured type metadata implementation.

The enhanced getTypeOf method now returns structured type information that enables better documentation generation. The multiple fallback strategies for resolving alias symbols (lines 536-547) improve robustness.

src/cartesian/Area.tsx (5)

75-78: LGTM!

The @inline JSDoc tag and exported BaseValue type are clean additions for documentation generation purposes. The type definition is concise and correctly captures the valid baseline values.

---

226-226: Good refactor: Using imported StackId type.

Using the shared StackId type from src/util/ChartUtils.ts improves consistency across the codebase. This aligns the public prop type with the internal type definition.

---

241-243: LGTM!

The JSDoc enrichment with @link and @see tags provides valuable documentation for users. The external link to d3-shape curves and the internal example reference are appropriate.

---

270-273: LGTM!

Expanding the Omit to exclude additional internal props ('path', 'pathRef', 'baseLine', 'dangerouslySetInnerHTML') appropriately narrows the public API surface by hiding implementation details from consumers.

---

1079-1083: LGTM!

The @provides and @consumes JSDoc annotations document the context relationships, which is valuable for understanding component hierarchy and for the automated API doc generation.

www/src/docs/api/AreaAPI.tsx (1)

1-602: Overall: Comprehensive API documentation.

The documentation covers the Area component's props thoroughly with appropriate descriptions, defaults, and examples. The event handlers are extensive but correctly inherited from the SVG props.

www/src/docs/api/LabelAPI.tsx (1)

99-132: LGTM!

The expanded type definitions for parentViewBox, position, value, and viewBox provide more informative API documentation. Using concrete union types like Required<CartesianViewBox> | Required<PolarViewBox> and the detailed position literal union helps users understand the expected values.

omnidoc/generateApiDoc.ts (5)

38-71: LGTM!

The splitTypeString function correctly handles nested structures by tracking bracket depth. This is essential for parsing complex union types without splitting inside generic parameters or object types.

---

76-141: LGTM!

The enhanced simplifyType function with the isInline flag allows preserving complex types when the source explicitly marks them for inline documentation. The recursive handling of union parts and the simplification heuristics are reasonable.

---

198-253: Well-structured link extraction helper.

The getLinksFromProp function handles various JSDoc tag formats (@see, @link, {@link ...}) and correctly parses URL/name pairs with deduplication. The prefix stripping for recharts.github.io URLs is a nice touch for cleaner internal links.

---

317-352: Good prop sorting implementation.

The sorting prioritizes: required props → recharts props → recharts events → other props → other events, with alphabetical ordering within each category. This provides a logical structure for API documentation.

---

271-272: LGTM!

Using the structured typeInfo object with isInline flag enables the documentation generator to respect the @inline JSDoc annotations and preserve complex types when appropriate.