Reviewing files that changed from the base of the PR and between 986928b and 1beb392.

• omnidoc/componentsAndDefaultPropsMap.ts (1 hunks)
• omnidoc/readProject.spec.ts (1 hunks)
• src/cartesian/ErrorBar.tsx (1 hunks)
• src/cartesian/Funnel.tsx (3 hunks)
• src/chart/CartesianChart.tsx (2 hunks)
• src/component/Label.tsx (1 hunks)
• src/component/Legend.tsx (2 hunks)
• src/component/Tooltip.tsx (2 hunks)
• src/component/TooltipBoundingBox.tsx (1 hunks)
• src/polar/Pie.tsx (4 hunks)
• src/polar/PolarAngleAxis.tsx (1 hunks)
• src/polar/PolarGrid.tsx (1 hunks)
• src/polar/PolarRadiusAxis.tsx (2 hunks)
• src/polar/Radar.tsx (3 hunks)
• src/polar/RadialBar.tsx (2 hunks)
• src/polar/defaultPolarAngleAxisProps.tsx (1 hunks)
• src/polar/defaultPolarRadiusAxisProps.tsx (1 hunks)
• src/shape/Curve.tsx (1 hunks)
• src/shape/Rectangle.tsx (3 hunks)
• src/shape/Sector.tsx (2 hunks)
• src/shape/Trapezoid.tsx (2 hunks)
• src/util/types.ts (5 hunks)
• storybook/stories/API/cartesian/Funnel.stories.tsx (2 hunks)
• storybook/stories/API/component/Legend.stories.tsx (3 hunks)
• storybook/stories/API/component/Tooltip.stories.tsx (2 hunks)
• storybook/stories/API/hooks/useActiveTooltipDataPoints.stories.tsx (2 hunks)
• storybook/stories/API/polar/Pie.stories.tsx (6 hunks)
• storybook/stories/API/polar/PolarAngleAxis.stories.tsx (0 hunks)
• storybook/stories/API/polar/PolarGrid.stories.tsx (3 hunks)
• storybook/stories/API/polar/PolarRadiusAxis.stories.tsx (2 hunks)
• storybook/stories/API/polar/Radar.stories.tsx (3 hunks)
• storybook/stories/API/polar/RadialBar.stories.tsx (2 hunks)
• storybook/stories/API/props/CartesianComponentShared.ts (0 hunks)
• storybook/stories/API/props/Legend.ts (2 hunks)
• storybook/stories/API/props/PolarComponentShared.ts (1 hunks)
• storybook/stories/API/props/RadialBarArgTypes.ts (1 hunks)
• storybook/stories/API/props/TooltipArgTypes.tsx (3 hunks)
• storybook/stories/API/shapes/Rectangle.stories.tsx (2 hunks)
• storybook/stories/API/shapes/Trapezoid.stories.tsx (2 hunks)
• storybook/stories/Examples/Tooltip.stories.tsx (17 hunks)
• test/chart/RadialBarChart.spec.tsx (1 hunks)
• test/component/Tooltip/Tooltip.content.spec.tsx (2 hunks)
• test/polar/Radar.spec.tsx (2 hunks)
• www/src/docs/api/AreaChart.ts (5 hunks)
• www/src/docs/api/BarChart.ts (6 hunks)
• www/src/docs/api/ComposedChart.ts (6 hunks)
• www/src/docs/api/Cross.ts (6 hunks)
• www/src/docs/api/Curve.ts (2 hunks)
• www/src/docs/api/Dot.ts (0 hunks)
• www/src/docs/api/Funnel.ts (5 hunks)
• www/src/docs/api/FunnelChart.ts (1 hunks)
• www/src/docs/api/LabelList.ts (2 hunks)
• www/src/docs/api/Legend.ts (4 hunks)
• www/src/docs/api/LineChart.ts (3 hunks)
• www/src/docs/api/Pie.ts (16 hunks)
• www/src/docs/api/PolarAngleAxis.ts (6 hunks)
• www/src/docs/api/PolarGrid.ts (0 hunks)
• www/src/docs/api/PolarRadiusAxis.ts (7 hunks)
• www/src/docs/api/Polygon.ts (0 hunks)
• www/src/docs/api/Radar.ts (5 hunks)
• www/src/docs/api/RadialBar.ts (7 hunks)
• www/src/docs/api/Rectangle.ts (5 hunks)
• www/src/docs/api/ResponsiveContainer.ts (4 hunks)
• www/src/docs/api/ScatterChart.ts (1 hunks)
• www/src/docs/api/Sector.ts (8 hunks)
• www/src/docs/api/Tooltip.ts (13 hunks)
• www/src/docs/api/types.ts (1 hunks)

• storybook/stories/API/polar/PolarAngleAxis.stories.tsx
• www/src/docs/api/Polygon.ts
• storybook/stories/API/props/CartesianComponentShared.ts
• www/src/docs/api/PolarGrid.ts
• www/src/docs/api/Dot.ts

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Build, Test, Pack

src/shape/Curve.tsx (1)

101-104: Documentation improvements accurately reflect implementation defaults.

The JSDoc @defaultValue annotations correctly document the defaults applied in the getPath function (lines 125 and 129). This is a documentation-only improvement that will help external consumers understand prop behavior without reading implementation details.

Also applies to: 108-111

storybook/stories/API/props/PolarComponentShared.ts (4)

7-11: Confirm angleAxisId documented default matches implementation

You’re now documenting a default of '0' for angleAxisId. Please double‑check that all polar components using this prop actually default to 0 when it’s omitted; otherwise Omnidoc will advertise a default that isn’t really there.

---

15-18: stackId arg table addition looks consistent

Adding the table metadata (type + General category) for stackId is consistent with other props and keeps the default intentionally unspecified/“no default”, which matches the usual semantics of stacking.

---

22-26: Verify radiusAxisId default '0' is actually applied at runtime

Similar to angleAxisId, you’re documenting radiusAxisId as defaulting to '0'. Please confirm that the underlying components really use 0 as the default ID when radiusAxisId is omitted so Omnidoc doesn’t drift from the actual behavior.

---

31-35: Internal data arg wiring matches Omnidoc/Storybook pattern

Exporting data as a StorybookArg with category: 'Internal' and then grouping it under Internal mirrors the pattern used elsewhere for non-user-facing props and should keep these out of the public API tables while still being available to Omnidoc.

www/src/docs/api/Curve.ts (1)

8-8: LGTM! Fixed default value representations.

The changes correctly standardize the default value representations:

• Line 8: 'linear' is now properly represented as a string literal without extra quotes
• Line 58: false is now properly represented as a boolean instead of the string "'false'"

These fixes ensure consistency in how defaults are documented across the API.

Also applies to: 58-58

www/src/docs/api/ComposedChart.ts (4)

10-10: LGTM! String literal standardization.

The removal of extra quotes from string literal default values ('horizontal' and 'index') correctly aligns with TypeScript/JavaScript conventions and improves documentation consistency.

Also applies to: 37-37

---

86-86: No action needed—documentation is accurate.

The verification confirms that the actual default value for barCategoryGap in the CartesianChart component is '10%', which matches the documented defaultVal: '10%' at line 86. The type signature allows both Percentage | Number, but the implementation uses the percentage string '10%' as the default. No correction is required.

---

117-117: Verified: Boolean default value is correct.

The change to defaultVal: false (boolean) aligns with all component implementations: CartesianChart.tsx, PolarChart.tsx, and rootPropsSlice.ts all use boolean false as the default. Type definitions in src/util/types.ts document @defaultValue false for this boolean property. The standardization is accurate.

---

128-128: No issues found. The removal of 'auto' from baseValue type is correct.

The BaseValue type is defined as number | 'dataMin' | 'dataMax' in the implementation, and the code only handles these three values. 'auto' was never a valid option for baseValue, so removing it from the documentation aligns with the actual implementation and the PR's objective to remove non-functional props.

test/component/Tooltip/Tooltip.content.spec.tsx (1)

34-74: Update to expect isAnimationActive: 'auto' looks correct

The test expectations now align with the Tooltip default 'auto' both before interaction and on hover; payload shape remains consistent.

Also applies to: 76-177

www/src/docs/api/FunnelChart.ts (1)

23-32: Normalized margin.defaultVal to JSON string is consistent with other docs

Using a JSON string for margin.defaultVal while keeping the human-readable format entry matches the broader docs pattern and improves consistency.

src/component/Label.tsx (1)

107-115: Implicit label function type now aligned with LabelContentType

Allowing implicit label functions to return RenderableText | ReactElement (instead of just ReactElement<SVGElement>) matches LabelContentType and existing runtime behavior, and removes an unnecessary typing restriction.

www/src/docs/api/Cross.ts (1)

5-63: Numeric defaults normalized from string '0' to number 0

Switching defaultVal for the Cross coordinates and dimensions to numeric 0 is consistent with the declared Number type and the updated ApiProps.defaultVal typing.

www/src/docs/api/BarChart.ts (1)

7-15: BarChart default values normalized to match runtime behavior

The updated defaultVal entries for layout, syncMethod, margin, barCategoryGap, stackOffset, and reverseStackOrder now use proper literals/JSON strings instead of quoted representations, which better reflects the actual runtime defaults and aligns with the new default‑props/docs normalization across charts.

Also applies to: 34-42, 72-81, 83-91, 134-154, 156-166

src/shape/Trapezoid.tsx (1)

42-56: Exported defaultTrapezoidProps and use of resolveDefaultProps look sound

Promoting the trapezoid defaults to an exported defaultTrapezoidProps and resolving props via resolveDefaultProps preserves existing behavior while making the defaults reusable for documentation and tooling. The default keys all match Props, so this remains type‑safe with resolveDefaultProps.

src/polar/PolarGrid.tsx (1)

21-36: PolarGrid prop defaults documented consistently with implementation

gridType = 'polygon', radialLines = true, angleAxisId = 0, and radiusAxisId = 0 in the function signature line up with the new @defaultValue annotations on PolarGridProps. Looks good and should help omnidoc stay accurate.

www/src/docs/api/ResponsiveContainer.ts (1)

20-62: ResponsiveContainer default metadata matches intended behavior better

Switching minWidth and debounce defaults to numeric 0 and dropping defaults for aspect, minHeight, and onResize makes the docs closer to the actual API. Keeping width / height at '100%' while marking them required also aligns with how ResponsiveContainer is typically used.

www/src/docs/api/ScatterChart.ts (1)

23-32: ScatterChart margin default is now machine‑ and human‑readable

Using a JSON string in defaultVal plus the JS‑style object in format is a nice balance for tooling and docs, and removing fake null defaults for width/height avoids implying runtime defaults that don’t exist.

src/polar/PolarRadiusAxis.tsx (1)

31-48: New PolarRadiusAxis props and defaults align with the axis model

Adding radiusAxisId, angle, orientation, and reversed with documented defaults (0 / 0 / right / false) brings the public API in line with the Redux‑backed axis model (selectPolarAxisScale/selectPolarAxisTicks) and the imported defaultPolarRadiusAxisProps. This should make axis configuration more explicit and better documented.

www/src/docs/api/Legend.ts (1)

32-32: LGTM! Default value formatting standardized.

The changes consistently remove extra quotes from string default values ('horizontal', 'center', 'bottom') and keep numeric values unquoted (14), improving documentation consistency across the API surface.

Also applies to: 42-42, 57-57, 72-72

www/src/docs/api/Radar.ts (3)

35-35: LGTM! Default values align with expanded public API.

The explicit false defaults for dot and label, and 'rect' for legendType correctly document the new default prop surface for Radar components.

Also applies to: 47-47, 57-57

---

68-69: LGTM! The 'auto' mode is preparatory work for SSR support.

The updated type and default value for isAnimationActive to include and default to 'auto' aligns with the broader pattern across components. Based on learnings, this is preparatory work for future SSR support.

---

99-99: LGTM! Animation easing default documented.

The 'ease' default for animationEasing is now explicitly documented.

storybook/stories/API/shapes/Trapezoid.stories.tsx (3)

5-5: LGTM! Import cleanup.

Removing isAnimationActive from the import aligns with the new pattern of defining animation controls directly in argTypes.

---

170-196: LGTM! Explicit table metadata improves Storybook documentation.

Adding table metadata with type summaries and default values (0) for upperWidth, lowerWidth, x, and y provides better control visibility in Storybook.

---

201-208: LGTM! New animation control exposed.

The isUpdateAnimationActive argType with boolean | "auto" type and false default provides explicit animation control for component updates, consistent with the broader animation control pattern across components.

www/src/docs/api/AreaChart.ts (3)

13-13: LGTM! String default values standardized.

The default values for layout ('horizontal'), syncMethod ('index'), and stackOffset ('none') are now consistently formatted without extra quotes.

Also applies to: 40-40, 89-89

---

78-78: LGTM! Margin default now uses JSON string format.

The margin default value is now represented as a JSON string ('{"top":5,"right":5,"bottom":5,"left":5}'), standardizing the representation of object defaults across the documentation.

---

110-110: The review comment is based on incorrect assumptions about a non-existent breaking change.

The verification shows that the BaseValue type definition in src/cartesian/Area.tsx (line 74) is number | 'dataMin' | 'dataMax', which exactly matches the documentation at www/src/docs/api/AreaChart.ts (line 110). There is no evidence that the 'auto' option ever existed for baseValue in the codebase—a comprehensive search found zero occurrences of baseValue paired with 'auto'. The current documentation is accurate and reflects the actual type definition with no breaking changes present.

Likely an incorrect or invalid review comment.

test/polar/Radar.spec.tsx (1)

314-314: LGTM! Test expectations align with expanded Radar public API.

Adding label: false to the expected event payloads correctly reflects the new default value in the expanded RadarProps interface, ensuring tests validate the complete payload shape.

Also applies to: 342-342

storybook/stories/API/hooks/useActiveTooltipDataPoints.stories.tsx (1)

7-7: LGTM! Migration to TooltipArgTypes pattern.

The refactoring from TooltipProps to TooltipArgTypes aligns with the broader pattern of using dedicated ArgTypes objects for Storybook stories, improving the separation between component prop types and Storybook documentation types.

Also applies to: 11-11, 37-37

omnidoc/readProject.spec.ts (1)

866-866: Test focus changed from layout to id property.

The test now verifies that AreaChart.id has no default value instead of testing AreaChart.layout. This aligns with the PR's goal of standardizing default values—layout now has an explicit default (documented in AreaChart.ts as 'horizontal'), while id correctly has no default.

storybook/stories/API/polar/RadialBar.stories.tsx (1)

6-6: LGTM! Migration to RadialBarArgTypes pattern.

The refactoring from RadialBarProps to RadialBarArgTypes is consistent with the broader Storybook story migration pattern, using dedicated ArgTypes objects for better separation of concerns between component props and Storybook documentation.

Also applies to: 10-10, 29-29

src/component/TooltipBoundingBox.tsx (1)

14-27: isAnimationActive: boolean | 'auto' wiring looks consistent

Allowing 'auto' in TooltipBoundingBoxProps and using it in the transition condition via isAnimationActive && active keeps runtime behavior sane ('auto' behaves like enabled). This aligns with the wider move to 'auto' defaults without introducing branching changes here.

Also applies to: 113-124

src/polar/defaultPolarRadiusAxisProps.tsx (1)

4-21: Explicit label: false default is appropriate

Setting label: false in defaultPolarRadiusAxisProps matches the “no label by default” behavior and keeps docs and runtime defaults aligned.

src/shape/Sector.tsx (1)

191-211: Exported defaultSectorProps + resolveDefaultProps is a solid refactor

The new defaultSectorProps surface is well‑typed (satisfies Partial<Props>), and using resolveDefaultProps keeps FC defaults explicit and reusable (e.g., via omnidoc) without changing rendering logic.

Also applies to: 213-226

storybook/stories/API/component/Tooltip.stories.tsx (1)

6-12: Switch to TooltipArgTypes keeps API story aligned with documented defaults

Using TooltipArgTypes both for argTypes and for seeding args via getStoryArgsFromArgsTypesObject is consistent with the props-docs refactor and should keep the story in sync with the Tooltip documentation.

Also applies to: 38-44

storybook/stories/API/polar/PolarRadiusAxis.stories.tsx (1)

33-45: Domain table metadata change is safe

The updated domain table metadata (type 'Array | Function', category 'General') is purely documentary and doesn’t affect runtime behavior; it looks fine.

src/component/Legend.tsx (1)

91-114: legendDefaultProps export and usage look correct

Exporting legendDefaultProps and resolving props through resolveDefaultProps makes the Legend defaults explicit and reusable (e.g., for omnidoc) without changing behavior. The values (align, layout, verticalAlign, iconSize, itemSorter) match the documented defaults and the new @defaultValue on itemSorter.

Also applies to: 155-161, 163-179

test/chart/RadialBarChart.spec.tsx (1)

376-393: Test now relies on chart/default RadialBar angles, which matches the new API

Using <RadialBar label={label} background dataKey="uv" isAnimationActive={false} /> without startAngle/endAngle is consistent with the RadialBar API tightening. The assertion still validates that 7 sectors are rendered, without depending on props that no longer exist.

src/polar/defaultPolarAngleAxisProps.tsx (1)

9-9: LGTM!

The addition of axisLineType: 'polygon' as a default prop aligns with the expanded public API surface for PolarAngleAxis.

www/src/docs/api/Rectangle.ts (1)

7-7: LGTM!

The standardization of default values from string '0' to number 0 improves consistency with the runtime defaults in defaultRectangleProps and matches the documented type of 'Number'.

Also applies to: 17-17, 27-27, 37-37, 47-47

storybook/stories/API/cartesian/Funnel.stories.tsx (1)

27-56: LGTM!

The migration from imported props to inline argTypes with comprehensive metadata (description, type, defaultValue, category) improves Storybook documentation and control generation. The default values align with the expanded Funnel component API.

storybook/stories/API/component/Legend.stories.tsx (1)

5-5: LGTM!

The refactor from LegendProps to LegendArgTypes improves semantic clarity, as these are Storybook argument type definitions rather than component props. The change is consistent with the broader pattern of using typed StorybookArgs across the codebase.

Also applies to: 10-10, 39-39, 102-102

src/shape/Rectangle.tsx (3)

75-114: LGTM!

The JSDoc @defaultValue comments provide clear inline documentation for the Rectangle props, improving developer experience and API discoverability.

---

119-133: LGTM!

The exported defaultRectangleProps constant provides a single source of truth for Rectangle defaults, typed with as const satisfies Partial<Props> for type safety. This aligns with the broader pattern of exporting default props across shape and chart components.

---

136-136: LGTM!

The usage of resolveDefaultProps with the exported defaultRectangleProps ensures type-safe default resolution and maintains consistency with the new pattern across the codebase.

Also applies to: 191-191

src/chart/CartesianChart.tsx (2)

15-25: LGTM!

The exported defaultCartesianChartProps provides a centralized, type-safe source of defaults for Cartesian chart components. The defaults are sensible: layout: 'horizontal', responsive: false, stackOffset: 'none', and accessibilityLayer: true align with typical chart usage patterns.

---

44-44: LGTM!

The use of resolveDefaultProps ensures type-safe default resolution and is consistent with the refactoring pattern across the codebase.

storybook/stories/API/polar/Pie.stories.tsx (3)

9-9: LGTM!

The adoption of StorybookArgs type for GeneralProps improves type safety and aligns with the Storybook typing standards used across other story files.

Also applies to: 11-11

---

12-143: LGTM!

The restructuring of argTypes with proper placement of defaultValue at the table level improves consistency and readability. The documented defaults are sensible for a Pie chart component: cx: '50%', cy: '50%', outerRadius: '80%', innerRadius: 0, startAngle: 0, endAngle: 360.

---

151-158: LGTM!

The addition of animationBegin with a default value of 400ms is consistent with other chart components and provides clear documentation for the animation delay prop.

storybook/stories/API/polar/Radar.stories.tsx (3)

8-8: LGTM!

The migration to StorybookArgs type improves type safety and consistency with the Storybook typing patterns used across the codebase.

Also applies to: 10-10, 32-32, 45-45

---

24-28: LGTM!

Adding defaultValue entries to the dot and label prop tables improves documentation clarity by explicitly showing that both default to false.

Also applies to: 37-41

---

64-73: LGTM!

The inline legendType argType with comprehensive type documentation and default value of 'rect' provides clear documentation and aligns with the pattern used in other polar component stories.

www/src/docs/api/Sector.ts (1)

7-7: LGTM! Default value standardization is consistent.

The conversion from string literals to primitive types (e.g., '0' → 0, 'false' → false) standardizes the default value representation across the API documentation and aligns with the broader PR pattern.

Also applies to: 17-17, 27-27, 37-37, 47-47, 57-57, 67-67, 77-77

storybook/stories/API/shapes/Rectangle.stories.tsx (1)

174-186: Verify the defaultValue discrepancy between argTypes and story args.

The argTypes define defaultValue: false for both isAnimationActive and isUpdateAnimationActive, but the API story args (lines 370-371) set them to true. This might be intentional (story-specific overrides), but please confirm this is the expected behavior.

src/util/types.ts (2)

755-755: LGTM! Type consolidation improves maintainability.

The change from an inline union type to ImplicitLabelType consolidates the type definition and improves maintainability. The relevant code snippet confirms that ImplicitLabelType includes all the necessary type options (boolean, string, number, ReactElement, function, and Props object).

---

1084-1144: LGTM! Default value documentation enhances API clarity.

The addition of JSDoc @defaultValue comments for CartesianChartProps properties provides valuable documentation for developers using these props. The default values align with the broader PR pattern of documenting defaults explicitly.

www/src/docs/api/LineChart.ts (2)

7-7: LGTM! Default value standardization is consistent.

Removing the surrounding quotes from string literals ('horizontal' and 'index') aligns the representation with primitive types and standardizes the documentation format across the codebase.

Also applies to: 34-34

---

42-67: LGTM! Removal of defaultVal for required props is correct.

The width, height, and data properties are marked as isOptional: false, indicating they are required props. Removing defaultVal for these required properties is appropriate since they must be explicitly provided by the user.

storybook/stories/API/polar/PolarGrid.stories.tsx (1)

30-45: Verify the argType structure for defaultValue placement.

The defaultValue is placed inside the table object (lines 34, 42), which is non-standard for Storybook argTypes. Typically, defaultValue should be at the top level of the argType definition, not nested within table. This structure might prevent Storybook from correctly recognizing and displaying the default values in the controls panel.

Expected structure:

gridType: {
  description: 'The type of polar grids.',
  defaultValue: 'polygon',  // at top level
  table: {
    type: { summary: "'polygon' | 'circle'" },
    category: 'General',
  },
}

www/src/docs/api/Funnel.ts (2)

63-64: LGTM! Animation default aligns with SSR preparatory work.

The change to isAnimationActive supporting 'auto' as the default value is consistent with the broader pattern across the codebase for preparing SSR support. Based on learnings, this mode is preparatory work for future SSR implementation.

---

26-26: LGTM! Default value documentation is consistent.

The defaultVal entries use appropriate primitive types (numbers and strings) and align with the standardization pattern across the PR.

Also applies to: 36-36, 74-74, 94-94

storybook/stories/Examples/Tooltip.stories.tsx (1)

23-23: LGTM! Consistent migration to TooltipArgTypes.

The change from TooltipProps to TooltipArgTypes is applied consistently across all imports, exports, and function calls throughout the file. This aligns with the broader PR pattern of standardizing Storybook argument type naming conventions.

Also applies to: 27-27, 51-51, 80-80, 133-133, 182-182, 220-220, 227-227, 275-275, 307-307, 336-336, 355-355, 376-376, 402-402, 440-440, 486-486, 515-515, 554-554, 574-574

src/component/Tooltip.tsx (1)

92-105: Axis axisId is now correctly wired into tooltip state

axisId is documented with a default of 0 and fed through defaultTooltipProps and setTooltipSettingsState, so it finally drives tooltip behavior instead of being a no-op. The useEffect dependency list (shared, trigger, axisId, activeFromProps, defaultIndexAsString) also looks complete and avoids stale settings.

Also applies to: 183-221

www/src/docs/api/PolarRadiusAxis.ts (1)

5-7: Radius axis default values look consistent; just keep them in sync with runtime defaults

The documented defaults for angle, type, allowDuplicatedCategory, reversed, label, axisLine, and tick match the expected behavior of PolarRadiusAxis and align with typical axis defaults in the codebase. Please just double‑check they stay in lock‑step with the actual default props (e.g., defaultPolarRadiusAxisProps) so omnidoc and runtime never diverge.

Also applies to: 15-18, 25-28, 52-55, 62-65, 84-87, 95-98

www/src/docs/api/PolarAngleAxis.ts (1)

43-48: Angle axis defaults line up with the new angle-axis defaults

The documented defaults for axisLine, axisLineType, tickLine, tick, type = 'category', and allowDuplicatedCategory all look correct and in line with the new defaultPolarAngleAxisProps pattern. Just ensure these values always mirror the actual exported defaults so omnidoc and the runtime behavior can’t drift apart.

Also applies to: 54-57, 64-67, 75-78, 115-118, 125-128

src/polar/Pie.tsx (1)

188-191: isAnimationActive: 'auto' wiring matches the SSR‑prep pattern

Widening isAnimationActive to boolean | 'auto' in both InternalPieProps and PieProps, and defaulting it to 'auto' in defaultPieProps, is consistent with the newer animation pattern (defer SSR decisions to animation logic rather than baking in Global.isSsr). SectorsWithAnimation passes this straight through to JavascriptAnimate, so as long as JavascriptAnimate already understands 'auto' (as in other chart components), this should behave as intended.

Based on learnings, this lines up with the existing SSR preparation work around 'auto' animation defaults.

Also applies to: 199-218, 808-831, 705-753

src/cartesian/Funnel.tsx (1)

65-86: Funnel defaults and 'auto' animation wiring are consistent with the new pattern

InternalFunnelProps and FunnelProps now both allow isAnimationActive?: boolean | 'auto', and defaultFunnelProps centralizes the defaults for animation timing, hide, lastShapeType, legendType, and nameKey. Using defaultFunnelProps both in resolveDefaultProps and as Funnel.defaultProps keeps runtime behavior and omnidoc defaults aligned, while TrapezoidsWithAnimation cleanly forwards isAnimationActive into JavascriptAnimate.

Looks good; just ensure JavascriptAnimate’s isActive prop supports the 'auto' value consistently with other components.

Also applies to: 91-135, 395-407, 268-316

omnidoc/componentsAndDefaultPropsMap.ts (1)

17-28: New component→defaultProps wiring looks consistent

The added imports and componentMetaMap entries (AreaChart/BarChart/ComposedChart/Funnel/FunnelChart/Legend/LineChart/Pie/PolarAngleAxis/PolarRadiusAxis/Radar/RadialBar/Rectangle/ScatterChart/Sector/Tooltip/Trapezoid) all point to the matching default*Props exports shown in the runtime code. This should give Omnidoc an accurate view of actual defaults without affecting behavior.

Also applies to: 36-63

src/polar/PolarAngleAxis.tsx (1)

31-93: Prop defaults are now explicitly documented and aligned with runtime defaults

The added @defaultValue annotations on PolarAngleAxisProps match the values in defaultPolarAngleAxisProps (e.g., axisLine: true, axisLineType: 'polygon', orientation: 'outer', tick: true, tickLine: true, tickSize: 8, type: 'category', zIndex: DefaultZIndexes.axis). This makes the public API surface much clearer without changing behavior.

www/src/docs/api/Pie.ts (1)

5-8: Pie docs now accurately mirror defaultPieProps

The updated defaultVal entries and widened isAnimationActive type (Boolean | "auto") align with defaultPieProps in src/polar/Pie.tsx. This removes stale or misleading defaults for props like data, shape, activeShape, and inactiveShape while accurately documenting the real runtime defaults.

Also applies to: 16-19, 27-30, 39-42, 72-75, 82-85, 98-101, 108-111, 118-121, 128-131, 146-149, 208-211, 218-221, 228-231, 238-241, 248-251

src/polar/RadialBar.tsx (1)

187-268: Animation and default-props integration for RadialBar looks coherent

• SectorsWithAnimation cleanly threads isAnimationActive, animationBegin, animationDuration, animationEasing, and the new onAnimationStart/onAnimationEnd callbacks into JavascriptAnimate, and uses a stable previousSectorsRef for smooth transitions.
• defaultRadialBarProps now centralizes the RadialBar defaults, and RadialBar uses resolveDefaultProps plus SetPolarGraphicalItem / SetRadialBarPayloadLegend / RadialBarImpl consistently with those defaults.
• Omnidoc and the RadialBar docs are wired to this same defaultRadialBarProps, so the public documentation should stay in sync with runtime behavior going forward.

Assuming existing tests for RadialBar animation still pass, the refactor looks good.

It’s worth running the RadialBar chart tests and a quick manual check of an animated RadialBarChart story to ensure the 'auto' animation mode behaves as expected with JavascriptAnimate.

Also applies to: 488-505, 633-657

src/polar/Radar.tsx (3)

14-14: LGTM!

The import of ImplicitLabelListType is correctly used for the label prop type declaration and aligns with the component's labeling functionality.

---

503-516: Well-structured default props export!

Exporting defaultRadarProps aligns with the PR's objective to make default values explicit and discoverable. The type assertion as const satisfies Partial<Props> provides excellent type safety while preserving literal types.

The defaults correctly match their JSDoc documentation (pending zIndex verification already noted above).

---

60-120: JSDoc documentation is accurate—no changes needed.

Verification confirms that the documented @defaultValue 100 for zIndex matches the implementation: DefaultZIndexes.area = 100 (line 515 in Radar.tsx).

All JSDoc @defaultValue annotations throughout this interface accurately reflect the corresponding default values in defaultRadarProps.

Reviewing files that changed from the base of the PR and between 1beb392 and 3569655.

• src/polar/Pie.tsx (4 hunks)
• src/polar/PolarRadiusAxis.tsx (2 hunks)
• src/polar/RadialBar.tsx (3 hunks)
• storybook/stories/API/props/TooltipArgTypes.tsx (2 hunks)
• www/src/docs/api/LabelList.ts (2 hunks)
• www/src/docs/api/Legend.ts (5 hunks)
• www/src/docs/api/RadialBar.ts (7 hunks)
• www/src/docs/api/types.ts (1 hunks)

• storybook/stories/API/props/TooltipArgTypes.tsx

• GitHub Check: Build, Test, Pack
• GitHub Check: Analyze (javascript-typescript)

www/src/docs/api/LabelList.ts (2)

53-57: Verify that offset defaultVal numeric type matches the LabelList runtime default

From examination of the codebase, the documentation change is verified as correct:

1. Runtime Default: The defaultLabelProps in src/component/Label.tsx explicitly sets offset: 5 as a number, and LabelList inherits from LabelProps which declares offset as number with JSDoc @defaultValue 5.

2. Consistent Pattern: The Label API documentation in www/src/docs/api/Label.ts uses the same numeric default: defaultVal: 5, confirming this is the established convention in the docs.

3. Type Alignment: The change from string literal "5" to numeric 5 properly aligns the documentation with the declared 'Number' type and prevents type mismatches in documentation rendering.

The docs are now in sync with the actual runtime behavior.

---

72-76: <!-- [scratchpad_start]
[task verify_labellist_props]
Verify that the underlying LabelList prop has type='boolean' and defaultVal=false in the implementation.

[observations]

• www/src/docs/api/LabelList.ts lines 72-76: Shows clockWise documented as type: 'boolean', defaultVal: false, isOptional: true
• src/component/LabelList.tsx line 55: Interface shows clockWise?: boolean; (optional boolean type)
• src/component/LabelList.tsx line 49: PolarLabelListEntry shows clockWise?: boolean;
• src/component/LabelList.tsx line 106: LabelList function destructures clockWise from props
• src/polar/Pie.tsx line 681, 690: Usage shows clockWise: false
• src/polar/RadialBar.tsx line 96, 104: Usage shows clockWise: false
• src/component/Label.tsx line 223, 227, 231: Uses clockWise in boolean context
• Storybook LabelListProps.ts line 93: Shows clockWise documented with Boolean type summary

[analysis]

• TypeScript type is correctly declared as optional boolean (clockWise?: boolean)
• Default behavior aligns with false through usage patterns in polar components (Pie, RadialBar)
• Documentation accurately reflects the prop signature
• No string form usage found; prop is consistently used as boolean throughout codebase

[pending]
None - sufficient evidence gathered.

[done]
Verification complete. Documentation changes are aligned with implementation.
[scratchpad_end]

Documentation clockWise prop is correctly typed as boolean with default false

The verification confirms the underlying LabelList prop is correctly declared as clockWise?: boolean in the implementation (src/component/LabelList.tsx line 55), and the default behavior is false as shown throughout usage in polar components (Pie, RadialBar, etc.). The documentation update in www/src/docs/api/LabelList.ts is accurate and properly aligned with the implementation.

www/src/docs/api/types.ts (1)

12-12: LGTM! Type extension supports object default values.

Adding Record<string, unknown> to the defaultVal union type appropriately extends the type system to handle object-type default values in API documentation.

www/src/docs/api/Legend.ts (3)

1-3: LGTM! Proper typing improves type safety.

Adding the ApiDoc type import and annotation to LegendAPI is good practice and ensures the documentation structure adheres to the defined schema.

---

74-74: Correct type alignment for iconSize default.

Changing iconSize from string '14' to number 14 properly aligns the default value with its documented type 'Number'.

---

34-34: Documentation defaults match component implementation and are properly normalized.

Verification confirms all three default values at lines 34, 44, and 59 are correctly normalized as plain strings and accurately reflect the Legend component's actual defaults:

• Line 34: layout defaults to 'horizontal' ✓
• Line 44: align defaults to 'center' ✓
• Line 59: verticalAlign defaults to 'bottom' ✓

src/polar/RadialBar.tsx (2)

74-74: Type widening is correct and consistent.

The RadialBarBackground type now correctly accepts boolean values, which aligns with the default value background: false at line 493 and the documentation.

---

488-505: Default values export looks good.

The exported defaultRadialBarProps object correctly defines default values, uses proper TypeScript constraints with as const satisfies Partial<RadialBarProps>, and aligns with the updated prop interface. The isAnimationActive: 'auto' default is appropriate as preparatory work for future SSR support.

www/src/docs/api/RadialBar.ts (1)

1-203: Documentation is consistent with code defaults.

All updated default values in this documentation file correctly match the defaults defined in src/polar/RadialBar.tsx. The type for isAnimationActive (line 72) properly includes the "auto" literal, and the default value (line 73) correctly reflects the new 'auto' default.

src/polar/PolarRadiusAxis.tsx (1)

57-60: Inside props/viewBox wiring looks sound and makes radius-axis geometry explicit

Intersecting InsideProps with PolarViewBoxRequired and then spreading ...viewBox after ...defaultsAndInputs ensures cx, cy, and radii are always present and that store-derived geometry wins over any legacy axis-level values. Tightening scale to RechartsScale also matches how ticks and coordinates are computed elsewhere.

This looks like a clean refactor with no obvious behavioral regressions.

Also applies to: 195-210

src/polar/Pie.tsx (3)

225-231: hide documentation now matches actual Pie behavior

The new doc block for hide (“If set true, the pie will not be displayed. @DefaultValue false”) correctly reflects what PieImpl does: it short‑circuits when hide is truthy and renders only an empty <Layer>, and the same flag is propagated into tooltip/legend settings via SetPieTooltipEntrySettings and SetPolarGraphicalItem.

This resolves the earlier ambiguity around whether hide was a no‑op and makes the prop’s semantics clear in both code and docs.

Also applies to: 833-848

---

808-821: defaultPieProps export and RequiresDefaultProps usage look correct

Exporting defaultPieProps and using it with RequiresDefaultProps<Props, typeof defaultPieProps> plus resolveDefaultProps gives omnidoc a single, typed source of defaults and ensures the component sees those defaults at runtime.

The chosen defaults (e.g., isAnimationActive: 'auto', label: false, labelLine: true, legendType: 'rect', minAngle: 0, nameKey: 'name', dataKey: 'value') are consistent with the existing implementation and the new JSDoc, and the satisfies Partial<Props> constraint will catch accidental divergence on the type side.

No issues from a typing or behavior standpoint.

---

165-197: isAnimationActive: boolean | 'auto' is correctly wired for SSR-aware animation control

The widening to boolean | 'auto' in both InternalPieProps and PieProps is sound. JavascriptAnimate accepts isActive?: boolean | 'auto' and resolves 'auto' to !Global.isSsr, enabling automatic animation control based on SSR context. This matches the intended behavior for future SSR support.

Reviewing files that changed from the base of the PR and between 3569655 and 15f6a41.

• src/polar/RadialBar.tsx (3 hunks)

• GitHub Check: Build, Test, Pack
• GitHub Check: Analyze (javascript-typescript)

src/polar/RadialBar.tsx (4)

74-74: LGTM! Type widened to support boolean values.

The type change correctly allows boolean values, aligning with the default value of false (line 496) and simplifying the API for users who want to enable/disable backgrounds without customization.

---

279-328: Excellent documentation consistency.

The @defaultValue JSDoc comments accurately match the corresponding values in defaultRadialBarProps (lines 491-508). This improves API discoverability and IDE autocomplete experience.

---

330-348: Documentation looks good.

The remaining @defaultValue JSDoc comments correctly match their corresponding values in defaultRadialBarProps. Props without defaults (like maxBarSize, tooltipType, onAnimationStart) correctly omit the annotation.

---

491-508: Well-structured default props export.

The exported defaultRadialBarProps enables external consumption (Storybook, docs, tests) and provides a single source of truth for defaults. The as const satisfies pattern ensures type safety while maintaining immutability, which helps prevent unnecessary re-renders when these defaults are used throughout the component tree.

Based on learnings, object-as-prop optimizations are important in Recharts for performance.