Omnidoc: Fix default values for Line, Scatter, CartesianGrid, ErrorBar, ReferenceArea, ReferenceDot#6665
Omnidoc: Fix default values for Line, Scatter, CartesianGrid, ErrorBar, ReferenceArea, ReferenceDot#6665
Conversation
WalkthroughExports default props for multiple cartesian components, adds them to omnidoc mapping, updates component prop interfaces (JSDoc defaultValue annotations and some prop renames/typings), standardizes Storybook/API documented default values to native types, and updates tests and stories to match new defaults (notably isAnimationActive -> 'auto'). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/cartesian/ReferenceArea.tsx (1)
120-122: Fix broken y‑axis scale null‑check
if (xAxisScale == null || !yAxisScale == null)is logically incorrect:!yAxisScale == nullis alwaysfalse, so the guard never fires whenyAxisScaleisnull/undefined, and subsequent code will try to use a missing scale.This should guard both axes directly:
- if (xAxisScale == null || !yAxisScale == null) { + if (xAxisScale == null || yAxisScale == null) { return null; }
🧹 Nitpick comments (7)
storybook/stories/API/props/RectangleProps.ts (2)
13-15: Consider control limitations for array values.The control type
'number'allows users to input only a single number value, but the prop acceptsnumber | number[]. Users won't be able to test array values (e.g.,[10, 5, 15, 20]for individual corner radii) through the Storybook UI controls.If array testing is important, consider using
type: 'object'ortype: 'text'with validation, though the current single-number control is still useful for the common case.
10-12: Optional: Minor grammar polish.The description could be refined for clarity:
- "If set to a value" (or "If a value is set")
- "If set to an array" (or "If an array is set")
- Consider "radii" instead of "radiuses" (both are valid, but radii is the more common plural)
src/cartesian/CartesianGrid.tsx (1)
91-112: JSDoc defaults and defaultCartesianGridProps are consistent and improve clarityThe added
@defaultValuetags for grid visibility, points/fills, syncWithTicks, axis IDs, and z-index line up withdefaultCartesianGridProps, and wiring them throughresolveDefaultPropsmakes the defaults explicit and reusable.One small maintainability nit: the JSDoc hard-codes
@defaultValue -100forzIndexwhile the actual default comes fromDefaultZIndexes.grid. IfDefaultZIndexes.gridever changes, the doc could drift. Consider either referencing the constant in the comment or documenting it indirectly (e.g. “defaults toDefaultZIndexes.grid”) to avoid duplication.Also applies to: 124-142, 147-172, 407-424
storybook/stories/API/props/AnimationProps.ts (1)
7-7: Animation arg defaults aligned with new semantics
- Adding
animateNewValueswithdefaultValue: trueunder the Animation category matches the intended default behavior.- Documenting
isAnimationActiveas defaulting to'auto'withtype: boolean | "auto"reflects the new “auto unless disabled” contract.If you want slightly richer docs, you could also add a
typeortable.type.summaryforanimateNewValues, but that’s optional.Also applies to: 29-32
omnidoc/omnidoc.spec.ts (1)
2-2: Consider dedicated equality library for test assertions.Using
shallowEqualfromreact-reduxworks, but it's primarily intended for React-Redux internals. Consider using a dedicated testing utility likelodash.isequalor implementing a custom shallow comparison for test assertions.That said, since
react-reduxis already a dependency andshallowEqualprovides the needed functionality, this is acceptable as-is.src/cartesian/ReferenceArea.tsx (1)
25-49: ReferenceArea JSDoc defaults are consistent with the intended APIThe added
@defaultValuetags forifOverflow,yAxisId,xAxisId, andzIndexcorrectly document the actual defaults (includingzIndex=DefaultZIndexes.area= 100). Re‑declaringzIndex?: numberon top ofZIndexableis slightly redundant but acceptable if you want per‑component docs.src/cartesian/Line.tsx (1)
33-40: Layout typing and SVG props exclusions are tightened upImporting
CartesianLayoutand using it incomputeLinePoints, plus omittinglayoutfromCurvePropsinLineSvgProps, avoids leaking the internal layout prop into the public API and makes the layout contract explicit at the computation boundary. One minor follow‑up you might consider is changingInternalLineProps['layout']to useCartesianLayoutas well to keep the union definition centralized.Also applies to: 200-200, 780-798
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
test/cartesian/__snapshots__/ReferenceArea.spec.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (27)
omnidoc/componentsAndDefaultPropsMap.ts(2 hunks)omnidoc/omnidoc.spec.ts(5 hunks)src/cartesian/CartesianGrid.tsx(5 hunks)src/cartesian/ErrorBar.tsx(1 hunks)src/cartesian/Line.tsx(6 hunks)src/cartesian/ReferenceArea.tsx(2 hunks)src/cartesian/ReferenceDot.tsx(3 hunks)src/cartesian/Scatter.tsx(3 hunks)src/state/selectors/lineSelectors.ts(1 hunks)storybook/stories/API/cartesian/CartesianGrid.stories.tsx(5 hunks)storybook/stories/API/cartesian/ReferenceArea.stories.tsx(1 hunks)storybook/stories/API/cartesian/Scatter.stories.tsx(4 hunks)storybook/stories/API/props/AnimationProps.ts(1 hunks)storybook/stories/API/props/CartesianComponentShared.ts(1 hunks)storybook/stories/API/props/RectangleProps.ts(2 hunks)test/cartesian/Line.spec.tsx(4 hunks)test/cartesian/ReferenceArea.spec.tsx(4 hunks)test/component/Legend.itemSorter.spec.tsx(4 hunks)test/component/Legend.spec.tsx(4 hunks)test/component/Tooltip/Tooltip.visibility.spec.tsx(1 hunks)www/src/docs/api/CartesianGrid.ts(6 hunks)www/src/docs/api/ErrorBar.ts(2 hunks)www/src/docs/api/Line.ts(10 hunks)www/src/docs/api/ReferenceArea.ts(3 hunks)www/src/docs/api/ReferenceDot.ts(3 hunks)www/src/docs/api/Scatter.ts(10 hunks)www/src/docs/api/types.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-19T14:08:01.708Z
Learnt from: PavelVanecek
Repo: recharts/recharts PR: 6659
File: www/src/components/GuideView/Performance/index.tsx:232-250
Timestamp: 2025-11-19T14:08:01.708Z
Learning: In Recharts version 3.4.2, object-as-prop optimizations were introduced to reduce unnecessary re-renders when new object references are passed as props. This affects the recommendation for the `react-perf/jsx-no-new-object-as-prop` ESLint rule.
Applied to files:
storybook/stories/API/cartesian/ReferenceArea.stories.tsxstorybook/stories/API/cartesian/Scatter.stories.tsx
📚 Learning: 2025-11-16T09:14:24.891Z
Learnt from: PavelVanecek
Repo: recharts/recharts PR: 6640
File: src/cartesian/Bar.tsx:156-159
Timestamp: 2025-11-16T09:14:24.891Z
Learning: In recharts, SSR (Server-Side Rendering) is not yet supported—charts don't render at all in SSR environments. The `isAnimationActive: 'auto'` mode is preparatory work for future SSR support, so testing of this mode should be deferred until SSR support is actually implemented.
Applied to files:
www/src/docs/api/Scatter.tswww/src/docs/api/Line.ts
🧬 Code graph analysis (11)
storybook/stories/API/props/AnimationProps.ts (1)
storybook/StorybookArgs.ts (1)
StorybookArg(13-48)
omnidoc/omnidoc.spec.ts (1)
omnidoc/DocReader.ts (1)
DefaultValue(1-1)
src/state/selectors/lineSelectors.ts (1)
storybook/stories/API/props/CartesianComponentShared.ts (1)
layout(75-83)
www/src/docs/api/CartesianGrid.ts (1)
www/src/docs/api/types.ts (1)
ApiDoc(20-26)
src/cartesian/ReferenceArea.tsx (2)
src/util/IfOverflow.ts (1)
IfOverflow(1-1)src/component/Label.tsx (1)
ImplicitLabelType(107-114)
storybook/stories/API/cartesian/CartesianGrid.stories.tsx (1)
src/cartesian/CartesianGrid.tsx (1)
CartesianGrid(426-555)
omnidoc/componentsAndDefaultPropsMap.ts (8)
src/cartesian/CartesianGrid.tsx (1)
defaultCartesianGridProps(407-424)src/cartesian/ErrorBar.tsx (1)
errorBarDefaultProps(207-217)src/component/Label.tsx (1)
defaultLabelProps(554-560)src/cartesian/Line.tsx (1)
defaultLineProps(698-717)src/cartesian/ReferenceArea.tsx (1)
referenceAreaDefaultProps(157-167)src/cartesian/ReferenceDot.tsx (1)
referenceDotDefaultProps(158-168)src/cartesian/ReferenceLine.tsx (1)
referenceLineDefaultProps(292-302)src/cartesian/Scatter.tsx (1)
defaultScatterProps(704-721)
src/cartesian/CartesianGrid.tsx (1)
src/state/cartesianAxisSlice.ts (1)
AxisId(8-8)
storybook/stories/API/cartesian/Scatter.stories.tsx (1)
storybook/StorybookArgs.ts (1)
StorybookArgs(59-61)
src/cartesian/Line.tsx (5)
src/util/types.ts (5)
AnimationDuration(604-604)AnimationTiming(602-602)DataKey(59-59)LegendType(68-79)CartesianLayout(49-49)src/component/LabelList.tsx (1)
ImplicitLabelListType(85-85)src/shape/Curve.tsx (1)
CurveType(59-75)src/state/cartesianAxisSlice.ts (1)
AxisId(8-8)src/zIndex/DefaultZIndexes.tsx (1)
DefaultZIndexes(4-81)
src/cartesian/Scatter.tsx (4)
src/state/cartesianAxisSlice.ts (1)
AxisId(8-8)src/util/types.ts (5)
DataKey(59-59)LegendType(68-79)TooltipType(80-80)AnimationDuration(604-604)AnimationTiming(602-602)src/shape/Curve.tsx (1)
CurveType(59-75)src/component/LabelList.tsx (1)
ImplicitLabelListType(85-85)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build, Test, Pack
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (37)
storybook/stories/API/props/RectangleProps.ts (1)
10-10: LGTM! Good typo and grammar fixes.The corrections improve the documentation quality: "rounderd" → "rounded" and "would falsely be add" → "would falsely be added".
Also applies to: 30-30
src/state/selectors/lineSelectors.ts (1)
102-103: LGTM! Defensive checks strengthen type safety.The added guard conditions appropriately validate
bandSizeandlayoutbefore passing them tocomputeLinePoints. The layout check ensures only'horizontal'or'vertical'values proceed, while the bandSize null check prevents undefined/null from being passed downstream. These changes align well with the type updates mentioned in the AI summary.storybook/stories/API/props/CartesianComponentShared.ts (1)
30-34: Aligning zAxisId default matches other axis defaultsSetting
zAxisId.defaultValueto0keeps it consistent withxAxisIdandyAxisIdand with the unified cartesian defaults. Looks good.www/src/docs/api/CartesianGrid.ts (1)
1-3: CartesianGrid API defaults now match runtime propsTyping
CartesianGridAPIasApiDocand switchingdefaultValentries to real booleans/arrays/strings (horizontal/vertical→true, points →[],fill→'none') brings the docs in line with the actualdefaultCartesianGridProps. This is a solid consistency fix.Also applies to: 43-56, 63-66, 93-96, 123-126
test/component/Tooltip/Tooltip.visibility.spec.tsx (1)
768-799: Legend payload expectations updated for new Line defaultsAdjusting the expected legend payload to use
isAnimationActive: 'auto'andtype: 'linear'matches the new Line defaults and keeps this Tooltip-visibility selector test in sync with runtime behavior.test/component/Legend.itemSorter.spec.tsx (1)
58-137: Legend.itemSorter tests now track Line’s new default propsUpdating the expected legend payloads so Lines carry
isAnimationActive: 'auto'andtype: 'linear'keeps these itemSorter tests consistent with the new Line defaults and legend payload shape. Assertions remain focused on sort order while reflecting the updated metadata.Also applies to: 151-231
test/cartesian/Line.spec.tsx (3)
302-337: onClick handler expectation correctly includes type: 'linear'The click-event test now asserting
type: 'linear'in the props passed toonClickaligns with Line’s new defaulttype. This keeps the test in sync with the component’s public behavior.
340-405: Hover handlers also reflecting default line typeBoth
onMouseOverandonMouseOutexpectations now includetype: 'linear'in the argument object, which is consistent with the default Line configuration and the onClick test above.
408-446: Touch-event test updated for default typeIncluding
type: 'linear'in the expected props foronTouchMovematches the other event tests and the Line default props, so the touch interaction coverage remains accurate.test/component/Legend.spec.tsx (2)
419-512: Legend custom function payload now matches Line defaultsIn the “content as a function” test, updating the expected payload entries to use
isAnimationActive: 'auto'for both lines matches the new Line default animation mode and keeps the Legend payload contract consistent across tests.
772-857: Legend React-component payload expectations updated for isAnimationActive='auto'The “content as a React Component” test now expecting
isAnimationActive: 'auto'in the Line payload objects is consistent with the updated animation defaults and with the other Legend/Tooltip tests.www/src/docs/api/types.ts (1)
12-12: LGTM! Type expansion supports array default values.The addition of
Array<unknown>to thedefaultValtype is necessary to support components with array defaults (e.g., CartesianGrid'shorizontalPointsandverticalPoints).src/cartesian/ErrorBar.tsx (1)
207-217: LGTM! Default props now publicly accessible for documentation.Exporting
errorBarDefaultPropsaligns with the broader pattern across Cartesian components and enables automated documentation generation.storybook/stories/API/cartesian/ReferenceArea.stories.tsx (1)
3-6: LGTM! Animation props correctly removed from ReferenceArea documentation.The removal of animation-related imports aligns with the PR objective, as these props have no effect on ReferenceArea.
www/src/docs/api/ErrorBar.ts (2)
19-19: LGTM! Default value type now matches prop type.Converting
widthdefault from string'5'to number5accurately reflects the actual type.
29-29: LGTM! Default value type now matches prop type.Converting
strokeWidthdefault from string'1.5'to number1.5accurately reflects the actual type.omnidoc/omnidoc.spec.ts (3)
113-117: LGTM! Object comparison now handles array and object defaults.The addition of object-aware comparison using
shallowEqualproperly handles array default values (e.g.,[]for CartesianGrid's grid points).
128-137: LGTM! Enhanced error messages improve debugging.The error messages now include both actual and documented values with their types, making it much easier to diagnose documentation inconsistencies.
160-179: LGTM! Standardized stringification improves comparison consistency.The centralized
stringifyandstringifyDefaultValuehelpers ensure consistent handling of default values across different documentation sources.omnidoc/componentsAndDefaultPropsMap.ts (2)
8-13: LGTM! Default props imports enable documentation generation.The new imports wire up the publicly exported default props from Cartesian components for documentation consistency checking.
23-30: LGTM! Component metadata map now includes all Cartesian components.The additions to
componentMetaMapenable automated default value consistency checking across API documentation, Storybook, and actual implementation.storybook/stories/API/cartesian/Scatter.stories.tsx (3)
169-169: LGTM! Animation props now defined inline with Scatter-specific defaults.Removing the generic animation props import and defining them inline (lines 339-350) correctly reflects Scatter's specific defaults (400ms duration, 'linear' easing) which differ from other components.
339-351: LGTM! Animation defaults match Scatter implementation.The inline definitions correctly document Scatter's animation defaults:
animationDuration: 400andanimationEasing: 'linear', matchingdefaultScatterPropsin the implementation.
356-452: LGTM! Style prop defaults accurately documented.All default values (
legendType: 'circle',line: false,label: false,shape: 'circle',lineJointType: 'linear',lineType: 'joint') correctly reflect the actual implementation defaults indefaultScatterProps.test/cartesian/ReferenceArea.spec.tsx (1)
336-376: Review comment is not applicable to the code.These are two separate, independent test cases with intentionally different radius values. The test at line 326 ("should render rectangle when shape is not defined") uses
radius={20}to verify DOM attribute rendering, while the test at line 468 ("should pass arguments to the shape function") usesradius={10}to verify that custom shape functions receive correct arguments. The spy expectation at line 484 correctly matches theradius={10}prop from line 475 in the same test. No inconsistency exists.Likely an incorrect or invalid review comment.
src/cartesian/ReferenceDot.tsx (2)
22-57: ReferenceDot JSDoc defaults align with runtime behaviorThe new JSDoc defaults for
r,ifOverflow,xAxisId, andyAxisIdare consistent with how the component behaves and with the new default props object. This keeps omnidoc and the runtime contract in sync.
158-177: ExportedreferenceDotDefaultPropsis well‑typed and consistentExporting
referenceDotDefaultPropswithas const satisfies Partial<Props>is clean and keeps defaults (ifOverflow: 'discard', axis IDs0,r: 10, styling, and zIndex) centralized and type‑checked. Usage viaresolveDefaultPropsinReferenceDotandPropsWithDefaultsfits the pattern used in other cartesian components.src/cartesian/ReferenceArea.tsx (1)
157-167: ExportedreferenceAreaDefaultPropsmatches documented defaultsThe exported
referenceAreaDefaultProps(discard overflow, axis IDs0,radius: 0,fill: '#ccc',fillOpacity: 0.5,stroke: 'none',strokeWidth: 1,zIndex: DefaultZIndexes.area) is coherent with the component’s behavior and the docs, and theas const satisfies Partial<Props>typing is appropriate.storybook/stories/API/cartesian/CartesianGrid.stories.tsx (1)
7-143: CartesianGrid ArgTypes now mirror component defaultsUsing
CartesianGridArgTypesand documenting defaults forxAxisId,yAxisId,horizontalPoints,verticalPoints, andsyncWithTicksbrings Storybook in line with the runtime defaults fromdefaultCartesianGridProps, which is exactly what omnidoc‑style usage needs.www/src/docs/api/ReferenceDot.ts (1)
5-23: ReferenceDot docs defaults aligned with component defaults
xAxisIdandyAxisIdnow default to0, andifOverflowto'discard', which matches the exportedreferenceDotDefaultProps. This keeps the public docs consistent with the actual behavior.Also applies to: 47-50
www/src/docs/api/ReferenceArea.ts (1)
5-23: ReferenceArea docs now match runtime default propsThe default values for
xAxisId,yAxisId(both0) andifOverflow('discard') correctly reflectreferenceAreaDefaultProps, so the API docs and implementation are in sync.Also applies to: 69-72
www/src/docs/api/Scatter.ts (1)
5-8: Scatter docs defaults updated to match component behavior and SSR planThe updated defaults for legend/shape/line/lineType, axis IDs (
0), and especiallyisAnimationActive: 'auto',animationDuration: 400, andanimationEasing: 'linear'are consistent with the shared cartesian defaults strategy and the'auto'animation mode being prepared for future SSR support. No further action needed here.Also applies to: 15-38, 45-48, 68-105, 122-135
src/cartesian/Line.tsx (1)
124-195: Line JSDoc defaults correctly mirrordefaultLinePropsThe
@defaultValueannotations onLineProps(animation flags/timings,connectNulls,dot,hide,isAnimationActive: 'auto',label,legendType: 'line',type: 'linear', axis IDs0,zIndex: 400) all line up with the exporteddefaultLineProps. ExportingdefaultLinePropswithas const satisfies Partial<Props>gives a solid, type‑checked single source of truth for omnidoc and forresolveDefaultProps.Also applies to: 698-717
www/src/docs/api/Line.ts (2)
10-10: LGTM! Default values properly typed.The conversion from string representations to actual primitives (e.g.,
'0'→0,'true'→true) improves the accuracy of the API documentation. The pattern is consistent: numbers and booleans use primitives, while string enum values remain as strings.Also applies to: 41-41, 51-51, 61-61, 83-83, 107-107, 131-131, 155-155, 188-188
223-224: LGTM! Animation mode expanded for SSR preparation.The type expansion to include
"auto"and the updated default value align with the preparatory work for future SSR support. Based on learnings.src/cartesian/Scatter.tsx (2)
155-155: LGTM! Animation mode expanded for SSR preparation.The type expansion to
boolean | 'auto'with default value'auto'is consistent with the preparatory work for future SSR support. The change is properly reflected in both internal and external props. Based on learnings.Also applies to: 219-222
170-238: LGTM! JSDoc annotations and default props export are well-aligned.The JSDoc
@defaultValueannotations provide helpful inline documentation, and the exporteddefaultScatterPropsconstant properly supports the omnidoc mapping mentioned in the PR objectives. All JSDoc values correctly match thedefaultScatterPropsvalues, withzIndexappropriately using theDefaultZIndexes.scatterconstant (which resolves to 600 as documented).Also applies to: 704-721
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6665 +/- ##
==========================================
- Coverage 94.26% 94.04% -0.23%
==========================================
Files 496 497 +1
Lines 42442 42531 +89
Branches 4859 4859
==========================================
- Hits 40009 39997 -12
- Misses 2428 2529 +101
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/cartesian/ReferenceArea.tsx(3 hunks)test/cartesian/ReferenceArea.spec.tsx(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- test/cartesian/ReferenceArea.spec.tsx
🧰 Additional context used
🧬 Code graph analysis (1)
src/cartesian/ReferenceArea.tsx (2)
src/util/IfOverflow.ts (1)
IfOverflow(1-1)src/component/Label.tsx (1)
ImplicitLabelType(107-114)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build, Test, Pack
🔇 Additional comments (3)
src/cartesian/ReferenceArea.tsx (3)
25-27: LGTM! JSDoc default value annotations improve API documentation.The added JSDoc
@defaultValueannotations forifOverflow,xAxisId, andyAxisIdcorrectly match the actual default values defined inreferenceAreaDefaultProps(lines 158-160).Also applies to: 35-41
157-167: LGTM! Default props are now properly exported and aligned with component interfaces.The export of
referenceAreaDefaultPropsimproves API transparency. The change fromrtoradius(line 161) correctly aligns with the Rectangle component's prop interface, as confirmed by the related test updates mentioned in the PR summary.
45-48: JSDoc default value is correct.Verification confirms that
DefaultZIndexes.areaequals 100, so the JSDoc annotation accurately documents the default value used at line 166.
| const yAxisScale = useAppSelector(state => selectAxisScale(state, 'yAxis', yAxisId, isPanorama)); | ||
|
|
||
| if (xAxisScale == null || !yAxisScale == null) { | ||
| if (xAxisScale == null || yAxisScale == null) { |
There was a problem hiding this comment.
Excellent fix for a critical operator precedence bug!
The corrected null check now properly validates that yAxisScale is null or undefined. The original condition !yAxisScale == null would have been evaluated as (!yAxisScale) == null, which always returns false because a boolean never equals null. This could have caused runtime errors when attempting to use a null scale downstream.
🤖 Prompt for AI Agents
In src/cartesian/ReferenceArea.tsx around line 120, the null check incorrectly
used '!yAxisScale == null' which evaluates as '(!yAxisScale) == null' and always
false; replace that expression with an explicit null/undefined check (use
'yAxisScale == null' to cover both null and undefined) so the condition reads
'if (xAxisScale == null || yAxisScale == null)' ensuring both scales are
properly validated before use.
Bundle ReportChanges will increase total bundle size by 504 bytes (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: recharts/bundle-cjsAssets Changed:
view changes for bundle: recharts/bundle-umdAssets Changed:
view changes for bundle: recharts/bundle-es6Assets Changed:
|
Description
Fixing documented default values.
ReferenceArea had animation props documented even though they do nothing so I removed it.
#6069
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.