fix: allow brush travelers to be controled by keys after mouse interaction#6285
Merged
fix: allow brush travelers to be controled by keys after mouse interaction#6285
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6285 +/- ##
==========================================
- Coverage 96.63% 96.62% -0.01%
==========================================
Files 221 221
Lines 20178 20182 +4
Branches 4139 4140 +1
==========================================
+ Hits 19499 19501 +2
- Misses 672 674 +2
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 396 bytes (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: recharts/bundle-umdAssets Changed:
view changes for bundle: recharts/bundle-cjsAssets Changed:
view changes for bundle: recharts/bundle-es6Assets Changed:
|
PavelVanecek
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were taking the scale value of the current X of the brush even if that X value was in the middle of two actual Brush scale values and trying to find it in the list of real scale values
Instead we should just be able to rely on indices since we're just updating the index anyways.
Now you can tab to chart, move travelers, move travelers with the mouse, tab to chart, and the travelers will continue to move with the keyboard wheras before the would not
Related Issue
fix #6265
Motivation and Context
fix #6265
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: