This repository was archived by the owner on Mar 2, 2026. It is now read-only.
[SYCL][Graphs] Change queue state query#162
Merged
EwanC merged 1 commit intosycl-graph-updatefrom May 16, 2023
Merged
Conversation
The current provided mechanism for querying the state of a queue is to use `get_info<info::queue::state>`. However, I think this has a couple of drawbacks: 1) The `info::queue::state` value which this extension defines isn't in an experimental namespace. 2) The `get_info` queries tend to map to underlying backend properties, in the implementation, see https://github.com/intel/llvm/tree/sycl/sycl/include/sycl/info . We are not defining a query for something that's backend specific, but backend agnostic, so `get_info` might not be the right API. Instead, I've changed the query to add a new `queue::ext_oneapi_get_state()` query. This has an experimental prefix, so won't conflict with any future core functionality, and can be easily implemented without fighting against the current `get_info()` mechanism.
reble
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current provided mechanism for querying the state of a queue is to use
get_info<info::queue::state>. However, I think this has a couple of drawbacks:The
info::queue::statevalue which this extension defines isn't in an experimental namespace. Although we could define it with an extra experimental namespace, e.gsycl::queue::ext_oneapi_graph::stateThe
get_infoqueries tend to map to underlying backend properties, in the implementation, see https://github.com/intel/llvm/tree/sycl/sycl/include/sycl/info. We are not defining a query for something that's backend specific, but backend agnostic, soget_infoI don't think is the right API.Instead, I've changed the query to add a new
queue::ext_oneapi_get_state()query. This has an experimental prefix, so won't conflict with any future core functionality, and can be easily implemented without fighting against the currentget_info()mechanism.