Conversation
anmonteiro
reviewed
Feb 26, 2025
| <img src={author.Author.imageUrl} /> | ||
| ______^ | ||
|
|
||
| TODO: This is a regression, the type is not correct should be a string |
Member
There was a problem hiding this comment.
I also caught this in one of my PRs. do you know if this is this related to the ppxlib upgrade? or have you not identified a cause yet?
Member
Author
There was a problem hiding this comment.
Didn't get deep into it, but want to revisit the locations of props/elements
Member
Author
There was a problem hiding this comment.
My plan now is to merge this, the React 19 and another PR investigating the locations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
=)The first runs of the CI for this PR will fail, it's all on the schedule