Skip to content

test: repro #840#842

Merged
anmonteiro merged 1 commit intomainfrom
anmonteiro/repro-840
Jul 23, 2024
Merged

test: repro #840#842
anmonteiro merged 1 commit intomainfrom
anmonteiro/repro-840

Conversation

@anmonteiro
Copy link
Member

No description provided.

"line": 4,
"col": 15
},
"type": "< bar : int; foo : string > Js.t -> React.element",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reproduces the issue @feihong reported: this type should be string, but instead it's the entire function type.

@anmonteiro anmonteiro requested review from davesnx and jchavarri June 23, 2024 05:13
Copy link
Collaborator

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tangentially related. This PR made me wonder if instead of disabling the failing test like we did in 14ac9e0 we should rather update it to reflect reality, for completion.

@anmonteiro anmonteiro merged commit ae18db0 into main Jul 23, 2024
@anmonteiro anmonteiro deleted the anmonteiro/repro-840 branch July 23, 2024 04:20
davesnx added a commit that referenced this pull request Nov 18, 2024
* 'main' of github.com:/reasonml/reason-react:
  fix: type of pipeable stream to allow objects with keys (#854)
  reason-react-ppx: + lower bound in ocaml
  add missing entries to changelog
  Fix multi-child fragment (#852)
  update compiler version in makefile cmd (#851)
  Add locations-check test (#844)
  fix: re-enable failing tests + fix location tests (#850)
  test: repro #840 (#842)
  Add CSS Box Alignment Module Level 3 (#847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants