refactor: convert error boundary code to Reason#839
Merged
anmonteiro merged 5 commits intomainfrom Jun 15, 2024
Merged
Conversation
davesnx
approved these changes
Jun 10, 2024
Member
davesnx
left a comment
There was a problem hiding this comment.
Very cursed code, but nicely done
davesnx
reviewed
Jun 10, 2024
jchavarri
added a commit
to jchavarri/opam-repository
that referenced
this pull request
Aug 19, 2024
CHANGES: * Add `isValidElement` (@r17x in reasonml/reason-react#837) * Add `startTransition` (@r17x in reasonml/reason-react#838) * Convert `ReasonReactErrorBoundary` to Reason instead of `%raw` JS. This has the benefit of skipping a hardcoded `require('react')` call (@anmonteiro in [reasonml/reason-react#839](reasonml/reason-react#839)) * Add CSS Box Alignment Module Level 3 (@davesnx in reasonml/reason-react#847) * Fix: Remove "unique `key` prop" warnings from multi-child fragment elements (@jchavarri in reasonml/reason-react#852)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: * Add `isValidElement` (@r17x in reasonml/reason-react#837) * Add `startTransition` (@r17x in reasonml/reason-react#838) * Convert `ReasonReactErrorBoundary` to Reason instead of `%raw` JS. This has the benefit of skipping a hardcoded `require('react')` call (@anmonteiro in [reasonml/reason-react#839](reasonml/reason-react#839)) * Add CSS Box Alignment Module Level 3 (@davesnx in reasonml/reason-react#847) * Fix: Remove "unique `key` prop" warnings from multi-child fragment elements (@jchavarri in reasonml/reason-react#852)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generated code looks like: