Restart waitpid call if we get interrupted.#409
Merged
Leonidas-from-XIV merged 1 commit intorealworldocaml:mainfrom Dec 7, 2022
Merged
Restart waitpid call if we get interrupted.#409Leonidas-from-XIV merged 1 commit intorealworldocaml:mainfrom
Leonidas-from-XIV merged 1 commit intorealworldocaml:mainfrom
Conversation
Collaborator
|
@tmcgilchrist Looks good, thanks for the contribution. If you add an entry to the changelog and reformat it should be ready to merge. |
Where [EINTR] means the call is interrupted by a caught signal or the signal does not have the SA_RESTART flag set.
Leonidas-from-XIV
approved these changes
Dec 7, 2022
Collaborator
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Looks good, ready to merge!
Contributor
Author
|
Thanks @Leonidas-from-XIV. Is it possible to get an opam release with this fix included? |
Collaborator
|
@tmcgilchrist I'll try to cut a release (2.2.0) when #397 is merged which should be hopefully this week. |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Jan 6, 2023
CHANGES: #### Added - Report all parsing errors in Markdown files (realworldocaml/mdx#389, @NathanReb) #### Changed - Preserve indentation in multiline OCaml blocks in .mli files (realworldocaml/mdx#395, @panglesd) #### Fixed - Fixed compatibility with Cmdliner 1.1.0 (realworldocaml/mdx#371, @Leonidas-from-XIV) - Report errors and exit codes of toplevel directives (realworldocaml/mdx#382, @talex5, @Leonidas-from-XIV) - Fix block locations in error reporting (realworldocaml/mdx#389, @NathanReb) - Include the content of the line that features the `part-end` MDX directive in the output, before that line would've been dropped (realworldocaml/mdx#374, realworldocaml/mdx#387, @Leonidas-from-XIV) - Handle EINTR signal on waitpid call by restarting the syscall. (realworldocaml/mdx#409, @tmcgilchrist) - Fix parsing of multiline toplevel phrases in .mli files (realworldocaml/mdx#394, realworldocaml/mdx#397, @Leonidas-from-XIV) #### Removed - Removed warning about missing semicolons added in MDX 1.11.0 and the automatic insertion of semicolons in the corrected files introduced in MDX 2.0.0. (realworldocaml/mdx#398, @Leonidas-from-XIV)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where [EINTR] means the call is interrupted by a caught signal or the signal does not have the SA_RESTART flag set.
This error was thrown when running an mdx test for ocurrent/ocurrent:
Based off a suggestion by @talex5 and this OCaml unix library code https://github.com/ocaml/ocaml/blob/trunk/otherlibs/unix/unix_unix.ml#L869-L871