Merged
Conversation
Member
Author
|
This should now pass the main Travis CI; @yminsky could you glance over and merge when happy? The other ocaml-ci should also now pass once ocurrent/ocaml-ci#81 is reviewed and merged, so ignore that failure for now. |
yminsky
approved these changes
Dec 8, 2019
Member
yminsky
left a comment
There was a problem hiding this comment.
Looks great! It also seems to fix cases where the Deferred was being replaced by some other random type from Cohttp_async.
Member
Author
|
I filed #3233 to track the promotion bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this diff seems suspiciously short. Need to investigate why more tests aren't affected by OCAML_ERROR_STYLE changing.
Update: this is because dune 2.0 terminates the build after the first promotion failure, instead of trying all possible rules. Investigating why, but not a blocker for this PR.
Closes #3227