Skip to content

Retain async initializers in actors in async_without_await#6436

Merged
SimplyDanny merged 1 commit intomainfrom
async-init-actor
Jan 14, 2026
Merged

Retain async initializers in actors in async_without_await#6436
SimplyDanny merged 1 commit intomainfrom
async-init-actor

Conversation

@SimplyDanny
Copy link
Collaborator

@SimplyDanny SimplyDanny commented Jan 14, 2026

Resolves #6423.

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 14, 2026 •
edited
Loading

1 Warning
⚠️ This PR may need tests.
20 Messages
📖 Building this branch resulted in a binary size of 27224.13 KiB vs 27222.4 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.79 s vs 0.75 s on main (5% slower).
📖 Linting Alamofire with this PR took 0.99 s vs 1.05 s on main (5% faster).
📖 Linting Brave with this PR took 6.94 s vs 6.94 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 22.86 s vs 22.62 s on main (1% slower).
📖 Linting Firefox with this PR took 11.05 s vs 10.89 s on main (1% slower).
📖 Linting Kickstarter with this PR took 7.66 s vs 7.62 s on main (0% slower).
📖 Linting Moya with this PR took 0.44 s vs 0.45 s on main (2% faster).
📖 Linting NetNewsWire with this PR took 2.3 s vs 2.33 s on main (1% faster).
📖 Linting Nimble with this PR took 0.66 s vs 0.69 s on main (4% faster).
📖 Linting PocketCasts with this PR took 7.19 s vs 7.32 s on main (1% faster).
📖 Linting Quick with this PR took 0.38 s vs 0.42 s on main (9% faster).
📖 Linting Realm with this PR took 3.3 s vs 3.31 s on main (0% faster).
📖 Linting Sourcery with this PR took 1.8 s vs 1.81 s on main (0% faster).
📖 Linting Swift with this PR took 4.36 s vs 4.32 s on main (0% slower).
📖 Linting SwiftLintPerformanceTests with this PR took 0.33 s vs 0.36 s on main (8% faster).
📖 Linting VLC with this PR took 1.12 s vs 1.12 s on main (0% slower).
📖 Linting Wire with this PR took 17.57 s vs 17.54 s on main (0% slower).
📖 Linting WordPress with this PR took 11.56 s vs 11.53 s on main (0% slower).
📖 This PR fixed a violation in Firefox: /firefox-ios/Push/Autopush.swift:59:38: Warning: Declaration should not be async if it doesn't use await (async_without_await)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny enabled auto-merge (squash) January 14, 2026 21:30
@SimplyDanny SimplyDanny merged commit 9a634bc into main Jan 14, 2026
27 checks passed
@SimplyDanny SimplyDanny deleted the async-init-actor branch January 14, 2026 22:01
nadeemnali pushed a commit to nadeemnali/SwiftLint that referenced this pull request Feb 26, 2026
@SimplyDanny @nadeemnali
Retain async initializers in actors in async_without_await (realm…
7e67a6e 
…#6436)
nadeemnali pushed a commit to nadeemnali/SwiftLint that referenced this pull request Feb 26, 2026
@SimplyDanny @nadeemnali
Retain async initializers in actors in async_without_await (realm…
f5ceeb9 
…#6436)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive triggers for async_without_await in actor with init() async

2 participants

@SimplyDanny @SwiftLintBot