fix(mdxish): Unclosed curly brace and callout fail to render on MDXish#1333
Merged
Jadenzzz merged 3 commits intoreadmeio:nextfrom Feb 15, 2026
Conversation
eaglethrost
reviewed
Feb 12, 2026
eaglethrost
reviewed
Feb 12, 2026
| }); | ||
| }); | ||
|
|
||
| it('should escape unclosed braces in content with emojis', () => { |
Contributor
There was a problem hiding this comment.
Can we add more tests for other special characters, such as math notations, mandarin characters, etc?
E.g. 汉字 𠮷 {
Contributor
|
Code looks good, just requested more tests! Sorry this was an oversight on my part 🙏 |
Co-authored-by: Dimas Putra Anugerah <63914983+eaglethrost@users.noreply.github.com>
eaglethrost
approved these changes
Feb 13, 2026
Contributor
|
This PR was released!🚀 Changes included in v13.1.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
The
escapeUnbalancedBraces()function inpreprocess-jsx-expressions.tshad an edge case where it can't handle multi-byte characters such as emojiThis change converts the content to an array of unicode code points once at the start to ensure multi-byte characters are handled properly
Describe your changes in detail.
🧬 QA & Testing