Add ConnectionInformation#hostName/hostPort#2714
Merged
Conversation
- The host name and port are derived from the Host/X-Forwarded-*/Forwarded header associated with this request. - When X-Forwarded-*/Forwarded header does not specify a port, add a port as per the scheme
rstoyanchev
approved these changes
Mar 2, 2023
Member
Author
|
@rstoyanchev @pderop Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Mar 2, 2023
violetagg
added a commit
that referenced
this pull request
Mar 2, 2023
…lback option This change is in addition to PR #2714
violetagg
added a commit
that referenced
this pull request
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Host/X-Forwarded-*/Forwardedheader associated with this request.X-Forwarded-*/Forwardedheader does not specify a port, add a port as per the scheme