Add reflection hints for better native-image support#2432
Merged
Conversation
When a `ChannelHandler` is added to the `Netty` channel pipeline and if the `ChannelHandler` implements `ChannelInboundHandlers`/`ChannelOutboundHandlers`, `io.netty.channel.ChannelHandlerMask#mask0` will inspect the `ChannelHandler's` methods for `io.netty.channel.ChannelHandlerMask.Skip` annotation. When there are no reflection hints, `NoSuchMethodException` is thrown when trying to query the methods with reflection. This will lead to methods marked as not skippable, although the program will be able to run without any problems, when all methods are marked as not skippable, one might observe performance issues. Fixes #2419
Contributor
|
This PR looks fine to me, there is no conditional configuration but since this is just configuration query method access, the impact on footprint should be low. Also that's great to have tests checking no implementation is missed. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
ChannelHandleris added to theNettychannel pipeline and if theChannelHandlerimplements
ChannelInboundHandler/ChannelOutboundHandler,io.netty.channel.ChannelHandlerMask#mask0will inspect theChannelHandler'smethods forio.netty.channel.ChannelHandlerMask.Skipannotation.When there are no reflection hints,
NoSuchMethodExceptionis thrown when trying to query the methods with reflection.This will lead to methods marked as not skippable, although the program will be able to run
without any problems, when all methods are marked as not skippable, one might observe performance issues.
Fixes #2419