[test] Disable asynchronicity in OnDiscard bufferTimeout test#3861
Merged
[test] Disable asynchronicity in OnDiscard bufferTimeout test#3861
Conversation
chemicL
added a commit
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent test failures were observed where
bufferTimeoutcase inOnDiscardShouldNotLeakTestfailed occasionally due to flaky behaviour caused by the discard happening shortly after the assertion failed. The reason was a tiny delay which was not coordinated with the assertion. This change disables the asynchronous behaviuor of the case.