#3772: wrapped with await().untilAsserted#3779
Merged
chemicL merged 1 commit intoreactor:3.6.xfrom Apr 11, 2024
Merged
Conversation
chemicL
requested changes
Apr 10, 2024
Member
chemicL
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I think it's a good approach. Please rebase to target the 3.6.x branch and let's merge it 🚀
55ad51d to
fe2b1f9
Compare
Contributor
Author
|
@chemicL Thanks for your comment 🙇♂️ $ git remote add upstream https://github.com/reactor/reactor-core.git
$ git checkout -b 3.6.x upstream/3.6.x
$ git checkout 240330-test-fix
$ git rebase 3.6.x # conflict occurs at gradle.properties (i resolved it)
$ git push --force |
Member
|
Thanks! I changed the base and I think there won't be any issue, but next time consider using |
Contributor
Author
|
I see. thanks for your kindful comments 🙇♂️ |
chemicL
approved these changes
Apr 11, 2024
chemicL
added a commit
that referenced
this pull request
Apr 11, 2024
Member
|
Thank you for the contribution @chickenchickenlove 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped
Assertions.assertThat(disposable.isDisposed()).isTrue()withAwaitility.await().Because
disposable.dispose()is not finished yet right after latch reaches zero.Fixes #3772