Improve LoggerUtils support and add TestLoggerExtension#3123
Merged
simonbasle merged 8 commits into3.4.xfrom Aug 1, 2022
Merged
Improve LoggerUtils support and add TestLoggerExtension#3123simonbasle merged 8 commits into3.4.xfrom
simonbasle merged 8 commits into3.4.xfrom
Conversation
…plifying reflection and enabling better testing
OlegDokuka
approved these changes
Aug 1, 2022
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves
LoggerUtilsand adds supporting JUnit5 annotations in reactor-core tests:LoggerUtilsnow has support to redirect rather than copy/capture log messages when thelogger factory is installed early.
In reactor-core tests, a
TestLoggerExtensionis added that sets up aTestLoggerand activates capture/redirection viaLoggerUtils:TestLogger(configured depending on test annotations) andsets up
LoggerUtilswith saidTestLoggerParameterResolverit injects theTestLoggerinto the test casedisableCapture()The Extension should be applied to individual tests. Convenience annotations are provided that fine tune the
TestLoggerthat will be injected:@Captureshould the loggers capture log output, ie. go both to original logger and TestLogger@Redirectshould the loggers redirect log output, ie. only go to TestLogger