wip #1003 Add fuseable/conditional xxxDoOnEach#1157
Merged
simonbasle merged 3 commits intomasterfrom Apr 12, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
============================================
+ Coverage 83.63% 83.71% +0.07%
- Complexity 3667 3681 +14
============================================
Files 340 342 +2
Lines 27959 28022 +63
Branches 5220 5234 +14
============================================
+ Hits 23384 23459 +75
+ Misses 3006 3002 -4
+ Partials 1569 1561 -8
Continue to review full report at Codecov.
|
smaldini
reviewed
Apr 6, 2018
| @@ -0,0 +1,62 @@ | |||
| /* | |||
smaldini
reviewed
Apr 6, 2018
| if (Operators.validate(this.s, s)) { | ||
| this.s = s; | ||
| if (s instanceof Fuseable.QueueSubscription) { | ||
| @SuppressWarnings("unchecked") final Fuseable.QueueSubscription<T> qs = (Fuseable.QueueSubscription<T>) s; |
Contributor
There was a problem hiding this comment.
Can use Operators.as(Subscription) : QueueSubscription
smaldini
reviewed
Apr 6, 2018
|
|
||
| @Override | ||
| public void clear() { | ||
| if (qs != null) { |
smaldini
reviewed
Apr 6, 2018
| static class DoOnEachFuseableSubscriber<T> extends DoOnEachSubscriber<T> | ||
| implements Fuseable, Fuseable.QueueSubscription<T> { | ||
|
|
||
| private boolean syncFused; |
smaldini
suggested changes
Apr 6, 2018
Contributor
smaldini
left a comment
There was a problem hiding this comment.
Minor changes, I like the factorization even if slightly more overhead.
smaldini
reviewed
Apr 6, 2018
| done = true; //TODO verify if done should be set | ||
| } | ||
| catch (Throwable e) { | ||
| done = false; |
Contributor
There was a problem hiding this comment.
done should be true in any case I think.
smaldini
approved these changes
Apr 6, 2018
still needs to make all test non-fuseable and add fuseable + conditional tests.
still needs coverage of tryOnNext though :(
a5a3e28 to
653bf8d
Compare
chemicL
added a commit
that referenced
this pull request
Jan 21, 2026
- Remove DataFlowIssue suppressions related to NullAway issue #1157 - Update NullAway from 0.12.15 to 0.13.0 - Update ErrorProne from 2.42.0 to 2.46.0 (version used by NullAway 0.13.0) - Fix AtomicReferenceFieldUpdater nullability annotations in DelegateServiceScheduler - Remove unnecessary null check in LambdaMonoSubscriber (NullAway now handles this correctly) NullAway 0.13.0 resolves the issue with AtomicReferenceFieldUpdater and @nullable type parameters, allowing removal of 137 DataFlowIssue suppressions across 70 files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still needs to make all test non-fuseable and add fuseable + conditional
tests.