Skip to content

chore: minor refactors #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glennawatson merged 1 commit into from
Nov 26, 2023
Merged

chore: minor refactors #1619

glennawatson merged 1 commit into from
Nov 26, 2023

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Nov 21, 2023

Splitting up #1596, tried to avoid modifying the whitespace.

  • use TryGetValue over ContainsKey/lookup
  • Remove unneeded array duplication via ToArray
  • Invert ifs to improve readability

@codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2dff048) 87.85% compared to head (10f0134) 87.81%.

Files Patch % Lines
Refit/RequestBuilderImplementation.cs 81.13% 7 Missing and 3 partials ⚠️
Refit/FormValueMultimap.cs 97.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1619      +/-   ##
==========================================
- Coverage   87.85%   87.81%   -0.04%     
==========================================
  Files          33       33              
  Lines        2354     2347       -7     
  Branches      295      294       -1     
==========================================
- Hits         2068     2061       -7     
  Misses        207      207              
  Partials       79       79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyMakkison TimothyMakkison mentioned this pull request Nov 25, 2023
Closed
@glennawatson
Copy link
Contributor

glennawatson commented Nov 26, 2023

Happy to merge this one in when we get it compiling. Thanks

@TimothyMakkison
Copy link
Contributor Author

TimothyMakkison commented Nov 26, 2023 •
edited
Loading

Sorry, ran csharpier one more time. No potential logic changes 👍

@glennawatson glennawatson merged commit 3cbe67a into reactiveui:main Nov 26, 2023
@TimothyMakkison TimothyMakkison deleted the refactor branch November 26, 2023 23:30
@TimothyMakkison TimothyMakkison mentioned this pull request Nov 27, 2023
Merged
@github-actions
Copy link

github-actions bot commented Dec 11, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@glennawatson glennawatson glennawatson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @glennawatson