Skip to content

Minor optimizations and cleanup code. #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TimothyMakkison wants to merge 1 commit into from
Closed

Minor optimizations and cleanup code. #1596

TimothyMakkison wants to merge 1 commit into from

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Nov 13, 2023 •
edited
Loading

  • Remove unneeded usings
  • Remove some null checks (it looks like nullable annotations were hastily added so I kept most of the redundant checks in place)
  • Fixed typos
  • Inverted ifs and used early returns/continutes to reduce nesting
  • Removed unneeded parameterTypes.ToArray() call
  • Replaced dict.ContainsKey -> dict[key] with TryGetValue where appropiate

@TimothyMakkison TimothyMakkison marked this pull request as draft November 14, 2023 21:46
@TimothyMakkison
Copy link
Contributor Author

TimothyMakkison commented Nov 14, 2023

Converted to draft until I fix the whitespace

@codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (bca7448) 85.40% compared to head (d583996) 85.46%.

❗ Current head d583996 differs from pull request most recent head e013bfc. Consider uploading reports for the commit e013bfc to get more accurate results

Files Patch % Lines
Refit/RequestBuilderImplementation.cs 85.00% 3 Missing and 3 partials ⚠️
Refit/FormValueMultimap.cs 89.65% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
+ Coverage   85.40%   85.46%   +0.06%     
==========================================
  Files          33       33              
  Lines        1685     1686       +1     
  Branches      295      294       -1     
==========================================
+ Hits         1439     1441       +2     
+ Misses        167      166       -1     
  Partials       79       79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Nov 20, 2023
Merged
Merged
Merged
@TimothyMakkison
Copy link
Contributor Author

TimothyMakkison commented Nov 25, 2023

Closing because I've split this pr into #1617 and #1619

@github-actions
Copy link

github-actions bot commented Dec 10, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
@TimothyMakkison TimothyMakkison deleted the cleanup branch December 10, 2023 00:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TimothyMakkison