add example for DrawerNavigatorConfig#552
Merged
satya164 merged 5 commits intoreact-navigation:masterfrom Mar 30, 2017
Blackscr33n:DrawerNavigatorConfigExample
Merged
add example for DrawerNavigatorConfig#552satya164 merged 5 commits intoreact-navigation:masterfrom Blackscr33n:DrawerNavigatorConfigExample
satya164 merged 5 commits intoreact-navigation:masterfrom
Blackscr33n:DrawerNavigatorConfigExample
Conversation
matthamil
requested changes
Mar 3, 2017
Member
matthamil
left a comment
There was a problem hiding this comment.
I think this is a great addition to the current docs. However, I think an explanation behind this example would be very valuable to those experiencing the same problem you had. Maybe adding a short paragraph above the example explaining that you may want to change the drawer to be a scrollable view if you have many DrawerView.Items in the drawer?
grabbou
previously requested changes
Mar 3, 2017
| drawerWidth: 200, | ||
| drawerPosition: 'right', | ||
| contentComponent: props => <ScrollView><DrawerView.Items {...props} /></ScrollView> | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Author
|
Thanks for your reply! I will add a description soon! |
Member
|
Maybe a throw an image as well there to show how to add a cover image in the drawer. |
satya164
approved these changes
Mar 30, 2017
lintonye
added a commit
to lintonye/react-navigation
that referenced
this pull request
Apr 3, 2017
* master: Docs: Added clarification for header configuration (react-navigation#891) Fix gesturesEnabled regression (react-navigation#886) bump react-native-drawer-layout-polyfill (react-navigation#882) Fix rebase commands (react-navigation#870) Possibility to overwrite label's style if defined as string. (react-navigation#731) add example for DrawerNavigatorConfig (react-navigation#552) Workaround for screenProps in TabViewAnimated (react-navigation#862) Update Guide-Nested.md (react-navigation#813) remove ReactComponentWithPureRenderMixin (react-navigation#809)
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
* add example for DrawerNavigatorConfig * add explanation for the example
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-navigation
that referenced
this pull request
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue: #531
Updated the docs so it is easy to find a solution for a common problem with DrawerNavigator.