fix: make back button ripple visible#11386
Merged
kacperkapusciak merged 5 commits intomainfrom Aug 1, 2023
Merged
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #11386 +/- ##
=======================================
Coverage 75.48% 75.49%
=======================================
Files 190 190
Lines 5740 5742 +2
Branches 2260 2261 +1
=======================================
+ Hits 4333 4335 +2
Misses 1360 1360
Partials 47 47
☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The Expo app for the example from this branch is ready! |
|
This should absolutely be merged.. It fixes a bug that's been outstanding since 2021.. #9794 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jun 15, 2023
Summary: The Pressable component supports the `foreground` option for ripple. However, using it on old android api levels (e.g. android 5) crashes with ``` Error while updating property nativeForegroundAndroid' of a view managed by: RCTView null No virtual method setForeground(Landroid/ graphics/drawable/Drawable;)V in class Lcom/ facebook/react/views/view/ReactViewGroup; or its super classes ``` TouchableNativeFeedback.js has a check to make sure this does not happen [as seen here](https://github.com/facebook/react-native/blob/b0485bed0945061becace5af924fa60b17ab295f/packages/react-native/Libraries/Components/Touchable/TouchableNativeFeedback.js#L158) I also want to point out that this PR can be closed #30466 as it's already implemented ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID] [FIXED] - foreground ripple crashed on api < 23 For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #37901 Test Plan: tested locally on [another project](react-navigation/react-navigation#11386) because I wasn't able to get RN tester running Reviewed By: rshest Differential Revision: D46747310 Pulled By: NickGerleman fbshipit-source-id: 4ee9062f821f5d629a1a0151c2fef61d836d09a4
kacperkapusciak
approved these changes
Aug 1, 2023
kacperkapusciak
pushed a commit
that referenced
this pull request
Aug 1, 2023
Please provide enough information so that others can review your pull request. **Motivation** closes #9794 also observed that the ripple radius can be very slightly increased to be like in the native android toolbar why the `foreground` isn't simply `true`? see facebook/react-native#37901 **Test plan** tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request.
Motivation
closes #9794
also observed that the ripple radius can be very slightly increased to be like in the native android toolbar
why the
foregroundisn't simplytrue? see facebook/react-native#37901Test plan
tested locally