fix: only call onGestureStart when criteria met in drawer#10929
Merged
satya164 merged 2 commits intoreact-navigation:mainfrom Nov 18, 2022
Merged
fix: only call onGestureStart when criteria met in drawer#10929satya164 merged 2 commits intoreact-navigation:mainfrom
satya164 merged 2 commits intoreact-navigation:mainfrom
Conversation
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
12 tasks
satya164
requested changes
Oct 16, 2022
Member
satya164
left a comment
There was a problem hiding this comment.
Thanks for the PR. Can you make the same change in legacy implementation as well?
Contributor
Author
|
@satya164 thx for reviewing this. I noticed that in the legacy implementation it already works correctly. legacy_impl_working.mov |
This was referenced Oct 17, 2022
onGestureStart called although criteria not met (#10927)
kacperkapusciak
approved these changes
Nov 4, 2022
kacperkapusciak
pushed a commit
to josemak25/react-navigation
that referenced
this pull request
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request.
Motivation
Fixes #10927.
NOTE: I already put up a PR for the issue #10928. This PR is just in case you don't like the proposal I made there.
Test plan
See other PR for test plan