fix: build process excluding image assets in published package #4004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4004 +/- ##
=======================================
Coverage 79.29% 79.29%
=======================================
Files 90 90
Lines 2144 2144
Branches 957 960 +3
=======================================
Hits 1700 1700
Misses 442 442
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2025
fix: build process excluding image assets in published package
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2025
fix: build process excluding image assets in published package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Build command did not include the image assets related to the Ratings components. After our direct integration of AirbnbRating (Swipe/Tap) from the third party library, we included image assets for the default ones that users have the ability to select. The below mentioned issue correctly pointed out that there was a flaw in our build process.
Fixes #3997
Type of change
How Has This Been Tested?
Checklist
Additional context
After running yarn build, I verified that the image assets are present in the following location: ...\react-native-elements\node_modules@rneui\base\dist\AirbnbRating\images