-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: slider track alignment issue fix for new rn versions #4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: slider track alignment issue fix for new rn versions #4003
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4003 +/- ##
==========================================
- Coverage 79.29% 79.26% -0.03%
==========================================
Files 90 90
Lines 2144 2141 -3
Branches 960 922 -38
==========================================
- Hits 1700 1697 -3
Misses 442 442
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
looks good to me tested on expo 51 and 54 |
|
Tests are passing and I tested with example app and is behaving as expected. Details from my research below: This fix addresses a layout regression in recent React Native versions (0.74+) caused by Yoga 3.0+ layout engine improvements. The original code used negative margins (TRACK_STYLE = -1) to offset the absolutely-positioned minimum track. This was a workaround that relied on specific layout calculation quirks in Yoga 2.x. While Yoga 3.0's major absolute positioning fixes were disabled by default for compatibility, other layout improvements changed how negative margins interact with absolute positioning, causing track misalignment. This fix handles the following:
|
fix: slider track alignment issue fix for new rn versions
fix: slider track alignment issue fix for new rn versions
theianmay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More detail review above. Merged and closed, thank you!
Motivation
Slider Track alignment issues
Fixes #4002
Type of change
How Has This Been Tested?
exampleappChecklist
yarn docs-build-apiAdditional context