-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Upgrade React native Vector Icons library #3994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React native Vector Icons library #3994
Conversation
… favor of material design icons
- Extracted Pointer component to separate function component with proper TypeScript interface - Created standalone HighlightedButton component with defined prop types - Moved components outside of main Tooltip component to reduce nesting and improve readability - Updated component references to pass required props explicitly - Added proper TypeScript interfaces for component props (PointerProps, HighlightedButtonProps)
…n as *byType are now deprecated and masked as unsafe
- Added multiple security-related packages including minimist, path-to-regexp, and cross-spawn - Updated build tooling dependencies (webpack-dev-middleware, loader-utils) - Added runtime dependencies for Babel and Algolia search functionality
- Added webpack-dev-server and related build tooling for improved development workflow - Included essential security packages (cookie, express, serve-static) for server functionality - Added utility libraries (micromatch, tar, nanoid) to support new features
- Added resolutions for node-gyp, parse-path, and tough-cookie to address known vulnerabilities - Updated website package resolutions to include postcss, @sideway/formula, got, and socks for security patches
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3994 +/- ##
==========================================
+ Coverage 79.13% 79.29% +0.15%
==========================================
Files 90 90
Lines 2142 2144 +2
Branches 945 958 +13
==========================================
+ Hits 1695 1700 +5
+ Misses 444 442 -2
+ Partials 3 2 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tested locally, need to remove one duplicate import to get example to run but will address in a separate PR (as well as adding the test coverage). Thanks for all the work on this! |
Upgrade React native Vector Icons library
Upgrade React native Vector Icons library
theianmay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, I addressed something with the example app in a separate PR and Deepak will address documentation updates in a separate PR. Merged and closed, thank you!
Motivation
Upgraded React Native Vector Icons to latest Modular Version of icon packages.
[!CAUTION] Breaking Change
Type of change
How Has This Been Tested?
exampleappChecklist
yarn docs-build-apiAdditional context