Skip to content

Conversation

@deepktp
Copy link
Contributor

@deepktp deepktp commented Nov 3, 2025

Motivation

Upgraded React Native Vector Icons to latest Modular Version of icon packages.

  • Removed Older icons package
  • Added now using modular icons

[!CAUTION] Breaking Change

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

theianmay and others added 14 commits November 6, 2025 13:00
- Extracted Pointer component to separate function component with proper TypeScript interface
- Created standalone HighlightedButton component with defined prop types
- Moved components outside of main Tooltip component to reduce nesting and improve readability
- Updated component references to pass required props explicitly
- Added proper TypeScript interfaces for component props (PointerProps, HighlightedButtonProps)
…n as *byType are now deprecated and masked as unsafe
theianmay and others added 15 commits November 6, 2025 13:00
- Added multiple security-related packages including minimist, path-to-regexp, and cross-spawn
- Updated build tooling dependencies (webpack-dev-middleware, loader-utils)
- Added runtime dependencies for Babel and Algolia search functionality
- Added webpack-dev-server and related build tooling for improved development workflow
- Included essential security packages (cookie, express, serve-static) for server functionality
- Added utility libraries (micromatch, tar, nanoid) to support new features
- Added resolutions for node-gyp, parse-path, and tough-cookie to address known vulnerabilities
- Updated website package resolutions to include postcss, @sideway/formula, got, and socks for security patches
@deepktp deepktp marked this pull request as ready for review November 8, 2025 16:24
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.29%. Comparing base (5f4b430) to head (7e5712e).
⚠️ Report is 84 commits behind head on next.

Files with missing lines Patch % Lines
...ages/base/src/CheckBox/components/CheckBoxIcon.tsx 50.00% 1 Missing ⚠️
packages/base/src/Icon/Icon.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3994      +/-   ##
==========================================
+ Coverage   79.13%   79.29%   +0.15%     
==========================================
  Files          90       90              
  Lines        2142     2144       +2     
  Branches      945      958      +13     
==========================================
+ Hits         1695     1700       +5     
+ Misses        444      442       -2     
+ Partials        3        2       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theianmay
Copy link
Member

Tested locally, need to remove one duplicate import to get example to run but will address in a separate PR (as well as adding the test coverage). Thanks for all the work on this!

@theianmay theianmay merged commit 149bbb0 into react-native-elements:next Nov 15, 2025
8 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 15, 2025
Upgrade React native Vector Icons library
github-actions bot pushed a commit that referenced this pull request Nov 15, 2025
Upgrade React native Vector Icons library
@github-project-automation github-project-automation bot moved this to Closed or Merged 🏁 in Community Roadmap 🛣 Nov 16, 2025
@theianmay theianmay added this to the v5.0.0 milestone Nov 16, 2025
@theianmay theianmay added the component: Icon Issue related to Icon Component label Dec 4, 2025
@theianmay theianmay self-requested a review December 5, 2025 06:43
Copy link
Member

@theianmay theianmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, I addressed something with the example app in a separate PR and Deepak will address documentation updates in a separate PR. Merged and closed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Icon Issue related to Icon Component PR: Breaking Change 💥

Projects

Status: Closed or Merged 🏁

Development

Successfully merging this pull request may close these issues.

2 participants