Skip to content

fix(Skeleton): height/width prop incorrect typing #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 7 commits into from
Jun 18, 2023
Merged

fix(Skeleton): height/width prop incorrect typing #3802

arpitBhalla merged 7 commits into from
Jun 18, 2023

Conversation

@deepak-rawat78
Copy link
Contributor

@deepak-rawat78 deepak-rawat78 commented May 31, 2023 •
edited
Loading

Fixes #3799

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@netlify
Copy link

netlify bot commented May 31, 2023 •
edited
Loading

✅ Deploy Preview for react-native-elements ready!

Name Link
🔨 Latest commit 8e93abf
🔍 Latest deploy log https://app.netlify.com/sites/react-native-elements/deploys/648f2decb4d6e000087d430f
😎 Deploy Preview https://deploy-preview-3802--react-native-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@deepak-rawat78 deepak-rawat78 mentioned this pull request May 31, 2023
Closed
9 tasks
khushal87
khushal87 reviewed Jun 13, 2023
View reviewed changes
deepak-rawat78

This comment was marked as duplicate.

Sign in to view

@deepak-rawat78
Copy link
Contributor Author

deepak-rawat78 commented Jun 13, 2023

@khushal87 As per your suggestion, I have updated types of height and width in Skeleton.tsx.

khushal87
khushal87 reviewed Jun 13, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Merging #3802 (7fbc62d) into next (a440ec0) will not change coverage.
The diff coverage is n/a.

❗ Current head 7fbc62d differs from pull request most recent head 8e93abf. Consider uploading reports for the commit 8e93abf to get more accurate results

@@           Coverage Diff           @@
##             next    #3802   +/-   ##
=======================================
  Coverage   79.87%   79.87%           
=======================================
  Files          87       87           
  Lines        1824     1824           
  Branches      814      814           
=======================================
  Hits         1457     1457           
  Misses        362      362           
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/Skeleton/Skeleton.tsx 84.61% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla changed the title Issue: Skeleton height/width prop incorrect typing #3799 fix(Skeleton): height/width prop incorrect typing Jun 18, 2023
@arpitBhalla arpitBhalla merged commit b5a95f6 into react-native-elements:next Jun 18, 2023
github-actions bot pushed a commit that referenced this pull request Jun 18, 2023
@deepak-rawat78 @deepakrawat08
fix(Skeleton): height/width prop incorrect typing (#3802)
b9a0a65 
Co-authored-by: deepakrwt07 <deepakrawat65970@gmail.com>
github-actions bot pushed a commit that referenced this pull request Jun 18, 2023
@deepak-rawat78 @deepakrawat08
fix(Skeleton): height/width prop incorrect typing (#3802)
0ae12c4 
Co-authored-by: deepakrwt07 <deepakrawat65970@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khushal87 khushal87 khushal87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Skeleton height/width prop incorrect typing

4 participants

@deepak-rawat78 @khushal87 @arpitBhalla @deepakrawat08