Skip to content

fix(Avatar): improve component #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 2 commits into from
Jun 7, 2023
Merged

fix(Avatar): improve component #3760

arpitBhalla merged 2 commits into from
Jun 7, 2023

Conversation

@khushal87
Copy link
Member

@khushal87 khushal87 commented Mar 5, 2023 •
edited
Loading

Motivation

Fixes #3742 and other improvements in the Avatar component (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

  • The renderPlaceholderContent and placeholderStyle is not relevant anymore because of the change in the implementation of the Avatar component. The previous implementation isn't great. I don't see any use cases for the props as such. Open for suggestions and improvements.

@khushal87 khushal87 requested a review from arpitBhalla March 5, 2023 16:26
@codecov
Copy link

codecov bot commented Mar 5, 2023 •
edited
Loading

Codecov Report

Merging #3760 (637158d) into next (6ea6a97) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 637158d differs from pull request most recent head 3328a78. Consider uploading reports for the commit 3328a78 to get more accurate results

@@            Coverage Diff             @@
##             next    #3760      +/-   ##
==========================================
+ Coverage   79.39%   79.47%   +0.07%     
==========================================
  Files          87       87              
  Lines        1820     1822       +2     
  Branches      810      805       -5     
==========================================
+ Hits         1445     1448       +3     
+ Misses        370      369       -1     
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/Avatar/index.tsx 100.00% <ø> (ø)
packages/base/src/Avatar/Avatar.tsx 100.00% <100.00%> (+2.77%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla changed the title fix: improve avatar component fix(Avatar): improve component Mar 5, 2023
@arpitBhalla arpitBhalla added component: Avatar Issue related to Avatar Component v4-component Related to major changes in v4 PR: Breaking Change 💥 labels Mar 5, 2023
@khushal87
Copy link
Member Author

khushal87 commented May 21, 2023 •
edited
Loading

@arpitBhalla can we merge it? What are the plan's to create a merge and release this for the users?

@arpitBhalla
Copy link
Member

arpitBhalla commented May 22, 2023

Can you add the changes to migration docs?

@netlify
Copy link

netlify bot commented May 22, 2023 •
edited
Loading

✅ Deploy Preview for react-native-elements ready!

Name Link
🔨 Latest commit 3328a78
🔍 Latest deploy log https://app.netlify.com/sites/react-native-elements/deploys/646b9ddb3441a50008448ef9
😎 Deploy Preview https://deploy-preview-3760--react-native-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khushal87
Copy link
Member Author

khushal87 commented May 28, 2023

This https://reactnativeelements.com/docs/migration_guide? @arpitBhalla

@arpitBhalla
Copy link
Member

arpitBhalla commented May 28, 2023 •
edited
Loading

Yes. https://reactnativeelements.com/migration/migration-v3 this to be more specific

@arpitBhalla arpitBhalla merged commit dbb66c6 into react-native-elements:next Jun 7, 2023
@arpitBhalla
Copy link
Member

arpitBhalla commented Jun 7, 2023

@khushal87 can you update docs in another PR

github-actions bot pushed a commit that referenced this pull request Jun 7, 2023
@khushal87
fix(Avatar): improve component (#3760)
8423039
github-actions bot pushed a commit that referenced this pull request Jun 7, 2023
@khushal87
fix(Avatar): improve component (#3760)
953ba83
@khushal87
Copy link
Member Author

khushal87 commented Jun 7, 2023

@khushal87 can you update docs in another PR

Sure, I will do it, this weekend.

@khushal87 khushal87 mentioned this pull request Jun 10, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpitBhalla arpitBhalla Awaiting requested review from arpitBhalla

1 more reviewer

@kulak91 kulak91 kulak91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component: Avatar Issue related to Avatar Component PR: Breaking Change 💥 v4-component Related to major changes in v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Letter Avatar throws: WARN ReactImageView: Image source "null" doesn't exist

3 participants

@khushal87 @arpitBhalla @kulak91