Skip to content

Conversation

@khushal87
Copy link
Member

Motivation

The Rating component's documentation wasn't rendered due to a lack of entry in the sidebars.ts. This is fixed in the PR.

Fixes (issue)

The Rating component's documentation wasn't rendered due to a lack of entry in the sidebars.ts. This is fixed in the PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran the docusaurus locally and made sure it works.

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

NIL

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #3753 (c83af66) into next (8af8b09) will not change coverage.
The diff coverage is n/a.

❗ Current head c83af66 differs from pull request most recent head e2e3aea. Consider uploading reports for the commit e2e3aea to get more accurate results

@@           Coverage Diff           @@
##             next    #3753   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files          87       87           
  Lines        1824     1824           
  Branches      796      807   +11     
=======================================
  Hits         1449     1449           
  Misses        370      370           
  Partials        5        5           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla changed the title fix: rendering of Rating component in documentation fix(website): add Rating to sidebar Feb 18, 2023
@arpitBhalla arpitBhalla merged commit e5a4ed9 into react-native-elements:next Feb 18, 2023
github-actions bot pushed a commit to markrickert/react-native-elements that referenced this pull request Mar 3, 2023
github-actions bot pushed a commit to markrickert/react-native-elements that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants