Skip to content

tests: breaking change for @testing-library/react-native #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 6 commits into from
Dec 23, 2022
Merged

tests: breaking change for @testing-library/react-native #3714

arpitBhalla merged 6 commits into from
Dec 23, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Dec 20, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla changed the title WIP tests: upgrade @testing-library/react-native & fix breaking change Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022 •
edited
Loading

Codecov Report

Merging #3714 (3b3c6c5) into next (f3f620f) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 3b3c6c5 differs from pull request most recent head 303f4c8. Consider uploading reports for the commit 303f4c8 to get more accurate results

@@            Coverage Diff             @@
##             next    #3714      +/-   ##
==========================================
+ Coverage   79.40%   79.51%   +0.10%     
==========================================
  Files          87       87              
  Lines        1821     1821              
  Branches      804      804              
==========================================
+ Hits         1446     1448       +2     
+ Misses        370      368       -2     
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/Tooltip/Tooltip.tsx 82.85% <100.00%> (ø)
packages/base/src/Tab/Tab.tsx 60.31% <0.00%> (+3.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla changed the title tests: upgrade @testing-library/react-native & fix breaking change tests: breaking change for @testing-library/react-native Dec 23, 2022
@arpitBhalla arpitBhalla merged commit aa6ab1e into react-native-elements:next Dec 23, 2022
@arpitBhalla arpitBhalla deleted the testing branch December 23, 2022 19:17
github-actions bot pushed a commit that referenced this pull request Dec 23, 2022
@arpitBhalla
tests: breaking change for @testing-library/react-native (#3714)
8562d5c
github-actions bot pushed a commit that referenced this pull request Dec 23, 2022
@arpitBhalla
tests: breaking change for @testing-library/react-native (#3714)
e4bc312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arpitBhalla