Skip to content

feat(Swipeable): add minSlideWidth prop #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 5 commits into from
Dec 27, 2022
Merged

feat(Swipeable): add minSlideWidth prop #3688

arpitBhalla merged 5 commits into from
Dec 27, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Nov 23, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented Dec 10, 2022 •
edited
Loading

Codecov Report

Merging #3688 (d0f58ae) into next (c535531) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head d0f58ae differs from pull request most recent head a6507d6. Consider uploading reports for the commit a6507d6 to get more accurate results

@@            Coverage Diff             @@
##             next    #3688      +/-   ##
==========================================
- Coverage   79.51%   79.42%   -0.09%     
==========================================
  Files          87       87              
  Lines        1821     1823       +2     
  Branches      804      806       +2     
==========================================
  Hits         1448     1448              
- Misses        368      370       +2     
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/ListItem/ListItem.Swipeable.tsx 6.38% <0.00%> (-0.14%) ⬇️
packages/base/src/Tab/Tab.Item.tsx 95.45% <0.00%> (-4.55%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla changed the title WIP feat(Swipeable): add minSlideWidth prop Dec 10, 2022
@arpitBhalla arpitBhalla mentioned this pull request Dec 10, 2022
Closed
1 task
@arpitBhalla arpitBhalla linked an issue Dec 27, 2022 that may be closed by this pull request
Add min. swipe length prop #3686
Closed
@arpitBhalla arpitBhalla merged commit f5f5812 into react-native-elements:next Dec 27, 2022
@arpitBhalla arpitBhalla deleted the listitem-swipeable branch December 27, 2022 22:49
github-actions bot pushed a commit that referenced this pull request Dec 27, 2022
@arpitBhalla
feat(Swipeable): add minSlideWidth prop (#3688)
9984222
github-actions bot pushed a commit that referenced this pull request Dec 27, 2022
@arpitBhalla
feat(Swipeable): add minSlideWidth prop (#3688)
72b4ae2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: New Feature 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add min. swipe length prop

1 participant

@arpitBhalla