Skip to content

Conversation

@MaximFedarau
Copy link
Contributor

Motivation

Fix punctuation, remove link leading nowhere, repeated words.

Type of change

Docs fix.

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #3661 (63e04e2) into next (48795ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3661   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files          87       87           
  Lines        1821     1821           
  Branches      812      812           
=======================================
  Hits         1446     1446           
  Misses        370      370           
  Partials        5        5           
Impacted Files Coverage Δ
packages/base/src/Button/Button.tsx 90.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MaximFedarau
Copy link
Contributor Author

@arpitBhalla, update docs, so only docs check fails. I think it's ok?

@arpitBhalla
Copy link
Member

Docs are auto generated, fix typos in component file in packages/base

@MaximFedarau
Copy link
Contributor Author

@arpitBhalla, thanks. Done.

@MaximFedarau
Copy link
Contributor Author

Hey, @arpitBhalla , all tests are ok.

@arpitBhalla arpitBhalla changed the title docs: fix button docs text for version-4.0.0.0-rc.1 - bleeding edge docs(Button): fix typos Oct 25, 2022
@MaximFedarau
Copy link
Contributor Author

MaximFedarau commented Oct 26, 2022

@arpitBhalla , fixed all merge conflicts

@arpitBhalla
Copy link
Member

Hey, there's some issue with docs build, will merge this after that.

@arpitBhalla arpitBhalla merged commit fd289e0 into react-native-elements:next Oct 28, 2022
github-actions bot pushed a commit that referenced this pull request Oct 28, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Oct 28, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants