Skip to content

feat(SeachBar): add onKeyboardHide for android #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 3 commits into from
Oct 22, 2022
Merged

feat(SeachBar): add onKeyboardHide for android #3657

arpitBhalla merged 3 commits into from
Oct 22, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Oct 22, 2022 •
edited
Loading

Motivation

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla changed the title WIP feat(SeachBar): add onKeyboardHide for android Oct 22, 2022
This was linked to issues Oct 22, 2022
onSubmitEditing fires onCancel & cancel fires onCancel twice in Android #3247
Closed
Searchbar - Hiding the keyboard should not automatically trigger cancel() #3221
Closed
@codecov
Copy link

codecov bot commented Oct 22, 2022 •
edited
Loading

Codecov Report

Merging #3657 (d3f4322) into next (4ebfd47) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             next    #3657      +/-   ##
==========================================
- Coverage   79.23%   79.20%   -0.04%     
==========================================
  Files          87       87              
  Lines        1811     1813       +2     
  Branches      802      804       +2     
==========================================
+ Hits         1435     1436       +1     
- Misses        370      371       +1     
  Partials        6        6
Impacted Files Coverage Δ
packages/base/src/SearchBar/SearchBar-android.tsx 61.90% <50.00%> (-0.40%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla merged commit 7960f47 into react-native-elements:next Oct 22, 2022
@arpitBhalla arpitBhalla deleted the 3221 branch October 22, 2022 08:36
github-actions bot pushed a commit that referenced this pull request Oct 22, 2022
@arpitBhalla
feat(SeachBar): add onKeyboardHide for android (#3657)
e0df9ff
github-actions bot pushed a commit that referenced this pull request Oct 22, 2022
@arpitBhalla
feat(SeachBar): add onKeyboardHide for android (#3657)
2875db4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: New Feature 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

onSubmitEditing fires onCancel & cancel fires onCancel twice in Android Searchbar - Hiding the keyboard should not automatically trigger cancel()

1 participant

@arpitBhalla