Skip to content

Conversation

@abhinav-official
Copy link
Contributor

@abhinav-official abhinav-official commented Sep 14, 2022

Motivation

Fixes #3629
Continuous crash on interpolate animation when using TAB.
No dependencies required
A conditional check is added.

Fixes # (issue)
[TabView] iOS TabView issue #3629

Type of change

conditional check added which prevents crash on interpolate transitions.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Additional context

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #3635 (7ef9bd9) into next (d6e6b3f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 7ef9bd9 differs from pull request most recent head 98e3bf6. Consider uploading reports for the commit 98e3bf6 to get more accurate results

@@            Coverage Diff             @@
##             next    #3635      +/-   ##
==========================================
- Coverage   79.38%   79.33%   -0.05%     
==========================================
  Files          87       87              
  Lines        1809     1810       +1     
  Branches      801      802       +1     
==========================================
  Hits         1436     1436              
- Misses        367      368       +1     
  Partials        6        6              
Impacted Files Coverage Δ
packages/base/src/Tab/Tab.tsx 56.66% <0.00%> (-0.97%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla changed the title [TabView] iOS TabView issue #3629 fix(TabView): iOS TabView issue Sep 14, 2022
@arpitBhalla arpitBhalla merged commit b3fc37e into react-native-elements:next Sep 14, 2022
github-actions bot pushed a commit that referenced this pull request Sep 14, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Sep 14, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TabView] iOS TabView issue

2 participants