Skip to content

website: footer broken links #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 3 commits into from
Sep 16, 2022
Merged

website: footer broken links #3622

arpitBhalla merged 3 commits into from
Sep 16, 2022

Conversation

@OlivierJM
Copy link
Contributor

@OlivierJM OlivierJM commented Aug 25, 2022 •
edited
Loading

Motivation

Current link in the footer goes to a 404, though it seems like 3 links in the first section of the footer will redirect to the same page, I think it is better than a 404.

Fixes #3621

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@OlivierJM
Fix components link in the footer
5693ced 
Current link in the footer goes to a 404, though it seems like 3 links in the first section of the footer will redirect to the same page, I think it is better than a 404.
@OlivierJM OlivierJM mentioned this pull request Aug 25, 2022
Closed
1 task
@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #3622 (5bcab33) into next (b3fc37e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3622   +/-   ##
=======================================
  Coverage   79.29%   79.29%           
=======================================
  Files          87       87           
  Lines        1811     1811           
  Branches      802      802           
=======================================
  Hits         1436     1436           
  Misses        369      369           
  Partials        6        6

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla changed the title Fix components link in the footer website: footer broken links Sep 16, 2022
@arpitBhalla arpitBhalla merged commit e365805 into react-native-elements:next Sep 16, 2022
github-actions bot pushed a commit to dakshbhardwaj/react-native-elements that referenced this pull request Sep 18, 2022
@OlivierJM
website: footer broken links (react-native-elements#3622)
5ce46b2
github-actions bot pushed a commit to dakshbhardwaj/react-native-elements that referenced this pull request Sep 18, 2022
@OlivierJM
website: footer broken links (react-native-elements#3622)
07d2853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Docs 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Components link in the footer goes redirects to a 404 Page

2 participants

@OlivierJM @arpitBhalla