Skip to content

fix: dist output target #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 3 commits into from
Jul 31, 2022
Merged

fix: dist output target #3603

arpitBhalla merged 3 commits into from
Jul 31, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Jul 31, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla changed the title WIP fix: Jul 31, 2022
@arpitBhalla arpitBhalla changed the title fix: fix: dist output target Jul 31, 2022
@codecov
Copy link

codecov bot commented Jul 31, 2022 •
edited
Loading

Codecov Report

Merging #3603 (0f24795) into next (1246628) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3603   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files          87       87           
  Lines        1805     1805           
  Branches      799      799           
=======================================
  Hits         1437     1437           
  Misses        362      362           
  Partials        6        6

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 182861e into react-native-elements:next Jul 31, 2022
github-actions bot pushed a commit that referenced this pull request Jul 31, 2022
@arpitBhalla
fix: dist output target (#3603)
cc6be27
github-actions bot pushed a commit that referenced this pull request Jul 31, 2022
@arpitBhalla
fix: dist output target (#3603)
dba4704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arpitBhalla