Skip to content

fix: add children as prop #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 1 commit into from
Jul 19, 2022
Merged

fix: add children as prop #3583

arpitBhalla merged 1 commit into from
Jul 19, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Jul 19, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla linked an issue Jul 19, 2022 that may be closed by this pull request
Copying the example given in the documentation for Tab component leads to TS errors #3574
Closed
1 task
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #3583 (b4a45b8) into next (32e1136) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3583   +/-   ##
=======================================
  Coverage   79.24%   79.24%           
=======================================
  Files          87       87           
  Lines        1812     1812           
  Branches      796      796           
=======================================
  Hits         1436     1436           
  Misses        370      370           
  Partials        6        6

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit d7fd4e2 into react-native-elements:next Jul 19, 2022
@arpitBhalla arpitBhalla linked an issue Jul 19, 2022 that may be closed by this pull request
Typescript error when adding children to Card #3556
Closed
1 task
github-actions bot pushed a commit that referenced this pull request Jul 19, 2022
@arpitBhalla
fix: add children as prop (#3583)
e6f872e
github-actions bot pushed a commit that referenced this pull request Jul 19, 2022
@arpitBhalla
fix: add children as prop (#3583)
a439917
@arpitBhalla arpitBhalla mentioned this pull request Aug 2, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Copying the example given in the documentation for Tab component leads to TS errors Typescript error when adding children to Card

1 participant

@arpitBhalla