Skip to content

fix(Button): theme spacing xs error #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 4 commits into from
Jun 25, 2022
Merged

fix(Button): theme spacing xs error #3563

arpitBhalla merged 4 commits into from
Jun 25, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Jun 25, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

This was linked to issues Jun 25, 2022
Previews broken (undefined is not an object for te.spacing[M] or te.spacing) #3548
Closed
ListItem has issues on sample #3562
Closed
Unable to use Fab #3558
Closed
Bug with Button that imported like import { Button } from "@rneui/themed"; #3553
Closed
@codecov
Copy link

codecov bot commented Jun 25, 2022 •
edited
Loading

Codecov Report

Merging #3563 (77f1e44) into next (dd72676) will increase coverage by 0.17%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             next    #3563      +/-   ##
==========================================
+ Coverage   79.07%   79.24%   +0.17%     
==========================================
  Files          87       87              
  Lines        1811     1812       +1     
  Branches      813      813              
==========================================
+ Hits         1432     1436       +4     
+ Misses        373      370       -3     
  Partials        6        6
Impacted Files Coverage Δ
packages/themed/src/config/withTheme.tsx 86.11% <66.66%> (+10.43%) ⬆️
packages/base/src/Button/Button.tsx 90.66% <88.88%> (+0.38%) ⬆️
packages/themed/src/config/ThemeProvider.tsx 75.00% <100.00%> (-0.56%) ⬇️
packages/themed/src/AirbnbRating/index.tsx 0.00% <0.00%> (-100.00%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla changed the title fix: button xs error fix(Button): button xs error Jun 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2022

Hey, @arpitBhalla PR Preview Build succeeded! ✅

Install using

 npm i react-native-elements/react-native-elements#base-3563 react-native-elements/react-native-elements#themed-3563

@arpitBhalla arpitBhalla changed the title fix(Button): button xs error fix(Button): theme spacing xs error Jun 25, 2022
@arpitBhalla arpitBhalla merged commit 172499f into react-native-elements:next Jun 25, 2022
@arpitBhalla arpitBhalla deleted the button-fix branch June 25, 2022 15:20
github-actions bot pushed a commit that referenced this pull request Jun 25, 2022
@arpitBhalla
fix(Button): theme spacing xs error (#3563)
6311af3
github-actions bot pushed a commit that referenced this pull request Jun 25, 2022
@arpitBhalla
fix(Button): theme spacing xs error (#3563)
b21fa39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

1 participant

@arpitBhalla