Skip to content

Conversation

@navarroaxel
Copy link
Contributor

@navarroaxel navarroaxel commented May 24, 2022

Motivation

When I install react-native-safe-area-context@latest in conjunction with @rneui/base I get the following error:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: AwesomeProject@0.0.1
npm WARN Found: react-native-safe-area-context@3.4.1
npm WARN node_modules/react-native-safe-area-context
npm WARN peer react-native-safe-area-context@"^3.1.9" from @rneui/base@4.0.0-rc.4
npm WARN node_modules/@rneui/base
npm WARN peer @rneui/base@"4.0.0-rc.4" from @rneui/themed@4.0.0-rc.4
npm WARN node_modules/@rneui/themed
npm WARN 1 more (the root project)
npm WARN 1 more (the root project)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react-native-safe-area-context@"^3.1.9" from @rneui/base@4.0.0-rc.4
npm WARN node_modules/@rneui/base
npm WARN peer @rneui/base@"4.0.0-rc.4" from @rneui/themed@4.0.0-rc.4
npm WARN node_modules/@rneui/themed
npm WARN 1 more (the root project)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: AwesomeProject@0.0.1
npm WARN Found: react-native-safe-area-context@3.4.1
npm WARN node_modules/react-native-safe-area-context
npm WARN peer react-native-safe-area-context@"^3.1.9" from @rneui/base@4.0.0-rc.4
npm WARN node_modules/@rneui/base
npm WARN peer @rneui/base@"4.0.0-rc.4" from @rneui/themed@4.0.0-rc.4
npm WARN node_modules/@rneui/themed
npm WARN 1 more (the root project)
npm WARN 1 more (the root project)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react-native-safe-area-context@"^3.1.9" from @rneui/base@4.0.0-rc.4
npm WARN node_modules/@rneui/base
npm WARN peer @rneui/base@"4.0.0-rc.4" from @rneui/themed@4.0.0-rc.4
npm WARN node_modules/@rneui/themed
npm WARN 1 more (the root project)

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I updated the package.json and I package and tested this locally.

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #3545 (6343895) into next (570e513) will not change coverage.
The diff coverage is n/a.

❗ Current head 6343895 differs from pull request most recent head 693aa0a. Consider uploading reports for the commit 693aa0a to get more accurate results

@@           Coverage Diff           @@
##             next    #3545   +/-   ##
=======================================
  Coverage   79.24%   79.24%           
=======================================
  Files          87       87           
  Lines        1807     1807           
  Branches      792      792           
=======================================
  Hits         1432     1432           
  Misses        369      369           
  Partials        6        6           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@navarroaxel navarroaxel marked this pull request as ready for review May 24, 2022 18:24
@arpitBhalla arpitBhalla merged commit 7a811f9 into react-native-elements:next May 26, 2022
github-actions bot pushed a commit that referenced this pull request May 26, 2022
github-actions bot pushed a commit that referenced this pull request May 26, 2022
@navarroaxel navarroaxel deleted the patch-1 branch May 26, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants