Skip to content

docs: ThemeProvider code snippet #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 3 commits into from
May 20, 2022
Merged

docs: ThemeProvider code snippet #3536

arpitBhalla merged 3 commits into from
May 20, 2022

Conversation

@piyush97
Copy link
Contributor

@piyush97 piyush97 commented May 20, 2022 •
edited
Loading

Fixing syntax error on the example for title with mode

Motivation

I used the example and I realized there was a syntax error on the example, so I thought why not let you guys know about this
Fixes # (issue)

Type of change

  • This change requires a documentation update

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

piyush97 and others added 3 commits May 20, 2022 13:44
@codecov
Copy link

codecov bot commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #3536 (ea3f767) into next (7816555) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3536   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files          87       87           
  Lines        1806     1806           
  Branches      793      793           
=======================================
  Hits         1430     1430           
  Misses        369      369           
  Partials        7        7

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla changed the title Fixing syntax error on the example docs: ThemeProvider code snippet May 20, 2022
@arpitBhalla arpitBhalla merged commit a9b29d0 into react-native-elements:next May 20, 2022
@arpitBhalla
Copy link
Member

arpitBhalla commented May 20, 2022

Thanks for the contribution 🎉

github-actions bot pushed a commit to kedar09/react-native-elements that referenced this pull request May 21, 2022
@piyush97 @arpitBhalla
docs: ThemeProvider code snippet (react-native-elements#3536)
bb5dd2b 

Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
github-actions bot pushed a commit to kedar09/react-native-elements that referenced this pull request May 21, 2022
@piyush97 @arpitBhalla
docs: ThemeProvider code snippet (react-native-elements#3536)
263f6a8 

Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Docs 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@piyush97 @arpitBhalla