Skip to content

example: add missing props #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 1 commit into from
May 18, 2022
Merged

example: add missing props #3532

arpitBhalla merged 1 commit into from
May 18, 2022

Conversation

@Ming1996
Copy link
Contributor

@Ming1996 Ming1996 commented May 18, 2022 •
edited
Loading

Motivation

Fixies #3533

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla changed the title add missing props example: add missing props May 18, 2022
@arpitBhalla arpitBhalla linked an issue May 18, 2022 that may be closed by this pull request
Example app Button screen missing error #3533
Closed
1 task
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #3532 (4289000) into next (8ab30ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3532   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files          87       87           
  Lines        1806     1806           
  Branches      810      810           
=======================================
  Hits         1430     1430           
  Misses        369      369           
  Partials        7        7

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 06c8bae into react-native-elements:next May 18, 2022
@arpitBhalla
Copy link
Member

arpitBhalla commented May 18, 2022

Thanks for the contribution 🎉

github-actions bot pushed a commit to kedar09/react-native-elements that referenced this pull request May 19, 2022
@Ming1996
example: add missing props (react-native-elements#3532)
41c47d2
github-actions bot pushed a commit to kedar09/react-native-elements that referenced this pull request May 19, 2022
@Ming1996
example: add missing props (react-native-elements#3532)
954df1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Example app Button screen missing error

2 participants

@Ming1996 @arpitBhalla