Skip to content

fix(makeStyles): add Theme in makeStyle interface #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 3 commits into from
May 16, 2022
Merged

fix(makeStyles): add Theme in makeStyle interface #3526

arpitBhalla merged 3 commits into from
May 16, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented May 16, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla linked an issue May 16, 2022 that may be closed by this pull request
I cant acces to custom props from makeStyles method #3515
Closed
1 task
@codecov
Copy link

codecov bot commented May 16, 2022 •
edited
Loading

Codecov Report

Merging #3526 (5a059d4) into next (2ec13f9) will not change coverage.
The diff coverage is n/a.

❗ Current head 5a059d4 differs from pull request most recent head 149fc11. Consider uploading reports for the commit 149fc11 to get more accurate results

@@           Coverage Diff           @@
##             next    #3526   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files          87       87           
  Lines        1806     1806           
  Branches      810      810           
=======================================
  Hits         1430     1430           
  Misses        369      369           
  Partials        7        7
Impacted Files Coverage Δ
packages/themed/src/config/ThemeProvider.tsx 75.55% <ø> (ø)
packages/themed/src/config/makeStyles.ts 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 9d392bd into react-native-elements:next May 16, 2022
github-actions bot pushed a commit that referenced this pull request May 16, 2022
@arpitBhalla
fix(makeStyles): add Theme in makeStyle interface (#3526)
fa6b000
github-actions bot pushed a commit that referenced this pull request May 16, 2022
@arpitBhalla
fix(makeStyles): add Theme in makeStyle interface (#3526)
369a554
@arpitBhalla arpitBhalla deleted the 3515 branch May 17, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

I cant acces to custom props from makeStyles method

1 participant

@arpitBhalla