Skip to content

Conversation

@kedar09
Copy link
Contributor

@kedar09 kedar09 commented May 10, 2022

Fixes # (issue)
#3457

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • My changes generate no new warnings

Additional context

Screenshot_2022-05-10 rne-expo-app

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #3514 (e142223) into next (dc1d369) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3514   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files          87       87           
  Lines        1806     1806           
  Branches      810      810           
=======================================
  Hits         1430     1430           
  Misses        369      369           
  Partials        7        7           
Impacted Files Coverage Δ
packages/base/src/Dialog/Dialog.Actions.tsx 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla changed the title Dialog - action button issue - web fix(Dialog): Action button on web May 14, 2022
@arpitBhalla arpitBhalla linked an issue May 14, 2022 that may be closed by this pull request
1 task
@arpitBhalla arpitBhalla merged commit d835acc into react-native-elements:next May 14, 2022
github-actions bot pushed a commit that referenced this pull request May 14, 2022
* dialog box action button issue - web

* action button overflow - modal issue
github-actions bot pushed a commit that referenced this pull request May 14, 2022
* dialog box action button issue - web

* action button overflow - modal issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialog actions are rendered outside the dialog box on WEB

2 participants