Skip to content

feat(base): add makeStyles #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 6 commits into from
May 9, 2022
Merged

feat(base): add makeStyles #3510

arpitBhalla merged 6 commits into from
May 9, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented May 9, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla changed the title Update README.md feat(base): add makeStyles May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022 •
edited
Loading

Codecov Report

Merging #3510 (a246f45) into next (6224af4) will not change coverage.
The diff coverage is n/a.

❗ Current head a246f45 differs from pull request most recent head 481fdca. Consider uploading reports for the commit 481fdca to get more accurate results

@@           Coverage Diff           @@
##             next    #3510   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files          87       87           
  Lines        1778     1778           
  Branches      772      772           
=======================================
  Hits         1413     1413           
  Misses        359      359           
  Partials        6        6

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 2ba0764 into react-native-elements:next May 9, 2022
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@arpitBhalla
feat(base): add makeStyles (#3510)
c28f08f
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@arpitBhalla
feat(base): add makeStyles (#3510)
0fbba3b
@arpitBhalla arpitBhalla deleted the makestyle branch May 17, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: New Feature 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arpitBhalla