Skip to content

fix(Tab): indicator on first render #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 2 commits into from
May 6, 2022
Merged

fix(Tab): indicator on first render #3505

arpitBhalla merged 2 commits into from
May 6, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented May 6, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla linked an issue May 6, 2022 that may be closed by this pull request
Tab indicator randomly not displayed on first render #3407
Closed
1 task
@codecov
Copy link

codecov bot commented May 6, 2022 •
edited
Loading

Codecov Report

Merging #3505 (76d0372) into next (fd0bbb6) will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##             next    #3505      +/-   ##
==========================================
- Coverage   79.49%   79.45%   -0.04%     
==========================================
  Files          87       87              
  Lines        1775     1777       +2     
  Branches      772      772              
==========================================
+ Hits         1411     1412       +1     
- Misses        358      359       +1     
  Partials        6        6
Impacted Files Coverage Δ
packages/base/src/Tab/Tab.tsx 56.89% <21.05%> (-0.25%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 974d344 into react-native-elements:next May 6, 2022
github-actions bot pushed a commit that referenced this pull request May 6, 2022
@arpitBhalla
fix(Tab): indicator on first render (#3505)
0f04e51
github-actions bot pushed a commit that referenced this pull request May 6, 2022
@arpitBhalla
fix(Tab): indicator on first render (#3505)
a39355d
@arpitBhalla arpitBhalla deleted the 3407 branch May 7, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tab indicator randomly not displayed on first render

1 participant

@arpitBhalla