Skip to content

feat(Button): add title as children & new size, color, radius prop #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 15 commits into from
May 9, 2022
Merged

feat(Button): add title as children & new size, color, radius prop #3494

arpitBhalla merged 15 commits into from
May 9, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented May 3, 2022 •
edited
Loading

image

@codecov
Copy link

codecov bot commented May 4, 2022 •
edited
Loading

Codecov Report

Merging #3494 (782a7d7) into next (f71f16e) will decrease coverage by 0.14%.
The diff coverage is 81.25%.

❗ Current head 782a7d7 differs from pull request most recent head a31c673. Consider uploading reports for the commit a31c673 to get more accurate results

@@            Coverage Diff             @@
##             next    #3494      +/-   ##
==========================================
- Coverage   79.36%   79.21%   -0.15%     
==========================================
  Files          87       87              
  Lines        1783     1804      +21     
  Branches      772      791      +19     
==========================================
+ Hits         1415     1429      +14     
- Misses        362      368       +6     
- Partials        6        7       +1
Impacted Files Coverage Δ
packages/base/src/Chip/Chip.tsx 100.00% <ø> (ø)
packages/base/src/FAB/FAB.tsx 100.00% <ø> (ø)
packages/themed/src/config/withTheme.tsx 75.67% <ø> (ø)
packages/themed/src/config/ThemeProvider.tsx 75.55% <75.00%> (-3.02%) ⬇️
packages/base/src/Button/Button.tsx 90.27% <79.16%> (-6.09%) ⬇️
.../base/src/PricingCard/components/PricingButton.tsx 81.81% <100.00%> (+1.81%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla marked this pull request as draft May 5, 2022 15:30
@arpitBhalla
Copy link
Member Author

arpitBhalla commented May 5, 2022

Hey @mauris I am still working on this.

@react-native-elements react-native-elements deleted a comment from mauris May 5, 2022
@mauris
Copy link

mauris commented May 5, 2022

@arpitBhalla my bad

@arpitBhalla arpitBhalla marked this pull request as ready for review May 9, 2022 19:34
@arpitBhalla arpitBhalla changed the title feat(Button): add children as title feat(Button): add children as title, size, color, radius prop May 9, 2022
@arpitBhalla arpitBhalla changed the title feat(Button): add children as title, size, color, radius prop feat(Button): add title as children & new size, color, radius prop May 9, 2022
@arpitBhalla arpitBhalla merged commit 4774fae into react-native-elements:next May 9, 2022
@arpitBhalla arpitBhalla deleted the button-child branch May 9, 2022 20:30
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@arpitBhalla
feat(Button): add title as children,size, color, radius prop (#…
028acaa 
…3494)
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@arpitBhalla
feat(Button): add title as children,size, color, radius prop (#…
b601e81 
…3494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: New Feature 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpitBhalla @mauris