Skip to content

build: change build target #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 2 commits into from
May 3, 2022
Merged

build: change build target #3493

arpitBhalla merged 2 commits into from
May 3, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented May 3, 2022

Motivation

closes #3488

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #3493 (cdc8c56) into next (996027d) will not change coverage.
The diff coverage is n/a.

❗ Current head cdc8c56 differs from pull request most recent head 594ab1d. Consider uploading reports for the commit 594ab1d to get more accurate results

@@           Coverage Diff           @@
##             next    #3493   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files          87       87           
  Lines        1774     1774           
  Branches      773      773           
=======================================
  Hits         1393     1393           
  Misses        376      376           
  Partials        5        5

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 1d09c1e into react-native-elements:next May 3, 2022
github-actions bot pushed a commit that referenced this pull request May 3, 2022
@arpitBhalla
build: change build target (#3493)
c675b5f
github-actions bot pushed a commit that referenced this pull request May 3, 2022
@arpitBhalla
build: change build target (#3493)
bbe988b
@arpitBhalla arpitBhalla deleted the web-error branch May 3, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can not add to an existing expo project.

1 participant

@arpitBhalla