Skip to content

feat(Tooltip): add animationType prop #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 2 commits into from
May 9, 2022
Merged

feat(Tooltip): add animationType prop #3487

arpitBhalla merged 2 commits into from
May 9, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Apr 30, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented Apr 30, 2022 •
edited
Loading

Codecov Report

Merging #3487 (38f2455) into next (f64b147) will decrease coverage by 0.93%.
The diff coverage is 25.00%.

❗ Current head 38f2455 differs from pull request most recent head 0e44c7d. Consider uploading reports for the commit 0e44c7d to get more accurate results

@@            Coverage Diff             @@
##             next    #3487      +/-   ##
==========================================
- Coverage   79.45%   78.52%   -0.94%     
==========================================
  Files          87       87              
  Lines        1777     1774       -3     
  Branches      772      772              
==========================================
- Hits         1412     1393      -19     
- Misses        359      376      +17     
+ Partials        6        5       -1
Impacted Files Coverage Δ
packages/base/src/Tooltip/Tooltip.tsx 89.39% <25.00%> (ø)
packages/base/src/ListItem/ListItem.Accordion.tsx 8.33% <0.00%> (-71.67%) ⬇️
packages/base/src/Text/Text.tsx 100.00% <0.00%> (ø)
packages/base/src/Skeleton/Skeleton.tsx 84.61% <0.00%> (ø)
packages/base/src/Tab/Tab.tsx 57.14% <0.00%> (+0.24%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 52d2f27 into react-native-elements:next May 9, 2022
@arpitBhalla arpitBhalla deleted the tooltip-prop branch May 9, 2022 18:45
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@arpitBhalla
feat(Tooltip): add animationType prop (#3487)
10fe008
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@arpitBhalla
feat(Tooltip): add animationType prop (#3487)
755260e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: New Feature 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arpitBhalla